[Notifier] [Mattermost] [BC BREAK] Change constructor signature

OskarStark · OskarStark · commit 03ea4990f6ff · 2020-12-22T10:03:13.000+01:00
| Q | A | ------------- | --- | Branch? | 5.x, but BC BREAK for experimental bridge | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | --- | License | MIT | Doc PR | --- Follows #39545
diff --git a/src/Symfony/Component/Notifier/Bridge/Mattermost/CHANGELOG.md b/src/Symfony/Component/Notifier/Bridge/Mattermost/CHANGELOG.md
@@ -1,6 +1,14 @@
 CHANGELOG
 =========
 
+5.3.0
+-----
+
+* [BC BREAK] Changed signature of `MattermostTransport::__construct()` method from:
+  `public function __construct(string $token, string $channel, HttpClientInterface $client = null, EventDispatcherInterface $dispatcher = null, string $path = null)`
+  to:
+  `public function __construct(string $token, string $channel, ?string $path = null, HttpClientInterface $client = null, EventDispatcherInterface $dispatcher = null)`
+
 5.1.0
 -----
 
diff --git a/src/Symfony/Component/Notifier/Bridge/Mattermost/MattermostTransport.php b/src/Symfony/Component/Notifier/Bridge/Mattermost/MattermostTransport.php
@@ -31,7 +31,7 @@ final class MattermostTransport extends AbstractTransport
     private $channel;
     private $path;
 
-    public function __construct(string $token, string $channel, HttpClientInterface $client = null, EventDispatcherInterface $dispatcher = null, string $path = null)
+    public function __construct(string $token, string $channel, ?string $path = null, HttpClientInterface $client = null, EventDispatcherInterface $dispatcher = null)
     {
         $this->token = $token;
         $this->channel = $channel;
diff --git a/src/Symfony/Component/Notifier/Bridge/Mattermost/MattermostTransportFactory.php b/src/Symfony/Component/Notifier/Bridge/Mattermost/MattermostTransportFactory.php
@@ -43,7 +43,7 @@ public function create(Dsn $dsn): TransportInterface
         $host = $dsn->getHost();
         $port = $dsn->getPort();
 
-        return (new MattermostTransport($token, $channel, $this->client, $this->dispatcher, $path))->setHost($host)->setPort($port);
+        return (new MattermostTransport($token, $channel, $path, $this->client, $this->dispatcher))->setHost($host)->setPort($port);
     }
 
     protected function getSupportedSchemes(): array
diff --git a/src/Symfony/Component/Notifier/Bridge/Mattermost/Tests/MattermostTransportTest.php b/src/Symfony/Component/Notifier/Bridge/Mattermost/Tests/MattermostTransportTest.php
@@ -49,6 +49,6 @@ public function testSendNonChatMessageThrowsLogicException()
 
     private function createTransport(): MattermostTransport
     {
-        return (new MattermostTransport('testAccessToken', 'testChannel', $this->createMock(HttpClientInterface::class)))->setHost('host.test');
+        return (new MattermostTransport('testAccessToken', 'testChannel', null, $this->createMock(HttpClientInterface::class)))->setHost('host.test');
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ final class MattermostTransport extends AbstractTransport`
`31`	`31`	`private $channel;`
`32`	`32`	`private $path;`
`33`	`33`
`34`		`- public function __construct(string $token, string $channel, HttpClientInterface $client = null, EventDispatcherInterface $dispatcher = null, string $path = null)`
	`34`	`+ public function __construct(string $token, string $channel, ?string $path = null, HttpClientInterface $client = null, EventDispatcherInterface $dispatcher = null)`
`35`	`35`	`{`
`36`	`36`	`$this->token = $token;`
`37`	`37`	`$this->channel = $channel;`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ public function create(Dsn $dsn): TransportInterface`
`43`	`43`	`$host = $dsn->getHost();`
`44`	`44`	`$port = $dsn->getPort();`
`45`	`45`
`46`		`- return (new MattermostTransport($token, $channel, $this->client, $this->dispatcher, $path))->setHost($host)->setPort($port);`
	`46`	`+ return (new MattermostTransport($token, $channel, $path, $this->client, $this->dispatcher))->setHost($host)->setPort($port);`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`protected function getSupportedSchemes(): array`
Original file line number	Diff line number	Diff line change
`@@ -49,6 +49,6 @@ public function testSendNonChatMessageThrowsLogicException()`
`49`	`49`
`50`	`50`	`private function createTransport(): MattermostTransport`
`51`	`51`	`{`
`52`		`- return (new MattermostTransport('testAccessToken', 'testChannel', $this->createMock(HttpClientInterface::class)))->setHost('host.test');`
	`52`	`+ return (new MattermostTransport('testAccessToken', 'testChannel', null, $this->createMock(HttpClientInterface::class)))->setHost('host.test');`
`53`	`53`	`}`
`54`	`54`	`}`