bug #54506 [HttpFoundation] Set content-type header in RedirectResponse (smnandre)

chalasr · chalasr · commit 07b279cf2577 · 2024-04-06T15:06:17.000+02:00
This PR was submitted for the 7.1 branch but it was squashed and merged into the 5.4 branch instead. Discussion ---------- [HttpFoundation] Set content-type header in RedirectResponse | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | Fix #54434 | License | MIT The RedirectResponse has no content-type set, leading to the response using the "current" one (see issue #54434) As `setTargetUrl` set response body with HTML/UTF-8 content, it seems fair to add the matching header at this moment. (not sure if really a _bug_ or not so i'm targetting 7.1 for now) Commits ------- 954f1af [HttpFoundation] Set content-type header in RedirectResponse
diff --git a/src/Symfony/Component/HttpFoundation/RedirectResponse.php b/src/Symfony/Component/HttpFoundation/RedirectResponse.php
@@ -103,6 +103,7 @@ public function setTargetUrl(string $url)
 </html>', htmlspecialchars($url, \ENT_QUOTES, 'UTF-8')));
 
         $this->headers->set('Location', $url);
+        $this->headers->set('Content-Type', 'text/html; charset=utf-8');
 
         return $this;
     }
diff --git a/src/Symfony/Component/HttpFoundation/Tests/RedirectResponseTest.php b/src/Symfony/Component/HttpFoundation/Tests/RedirectResponseTest.php
@@ -44,6 +44,13 @@ public function testGenerateLocationHeader()
         $this->assertEquals('foo.bar', $response->headers->get('Location'));
     }
 
+    public function testGenerateContentTypeHeader()
+    {
+        $response = new RedirectResponse('foo.bar');
+
+        $this->assertSame('text/html; charset=utf-8', $response->headers->get('Content-Type'));
+    }
+
     public function testGetTargetUrl()
     {
         $response = new RedirectResponse('foo.bar');

Original file line number	Diff line number	Diff line change
`@@ -103,6 +103,7 @@ public function setTargetUrl(string $url)`
`103`	`103`	`</html>', htmlspecialchars($url, \ENT_QUOTES, 'UTF-8')));`
`104`	`104`
`105`	`105`	`$this->headers->set('Location', $url);`
	`106`	`+ $this->headers->set('Content-Type', 'text/html; charset=utf-8');`
`106`	`107`
`107`	`108`	`return $this;`
`108`	`109`	`}`
Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,13 @@ public function testGenerateLocationHeader()`
`44`	`44`	`$this->assertEquals('foo.bar', $response->headers->get('Location'));`
`45`	`45`	`}`
`46`	`46`
	`47`	`+ public function testGenerateContentTypeHeader()`
	`48`	`+ {`
	`49`	`+ $response = new RedirectResponse('foo.bar');`
	`50`	`+`
	`51`	`+ $this->assertSame('text/html; charset=utf-8', $response->headers->get('Content-Type'));`
	`52`	`+ }`
	`53`	`+`
`47`	`54`	`public function testGetTargetUrl()`
`48`	`55`	`{`
`49`	`56`	`$response = new RedirectResponse('foo.bar');`