feature #60922 [Form] Change UrlType default protocol (OskarStark)

nicolas-grekas · nicolas-grekas · commit 0cae29b13bec · 2025-06-27T17:26:23.000+02:00
This PR was merged into the 8.0 branch. Discussion ---------- [Form] Change `UrlType` default protocol | Q | A | ------------- | --- | Branch? | 8.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | -- | License | MIT Commits ------- c1f3c7e [Form] Change `default_protocol` default value to `null` in `UrlType`
diff --git a/UPGRADE-8.0.md b/UPGRADE-8.0.md
@@ -134,6 +134,30 @@ DoctrineBridge
    $type = $extractor->getType(Foo::class, 'property');
    ```
 
+Form
+----
+
+ * The `default_protocol` option in `UrlType` now defaults to `null` instead of `'http'`
+
+   *Before*
+   ```php
+   // URLs without protocol were automatically prefixed with 'http://'
+   $builder->add('website', UrlType::class);
+   // Input: 'example.com' → Value: 'http://example.com'
+   ```
+
+   *After*
+   ```php
+   // URLs without protocol are now kept as-is
+   $builder->add('website', UrlType::class);
+   // Input: 'example.com' → Value: 'example.com'
+
+   // To restore the previous behavior, explicitly set the option:
+   $builder->add('website', UrlType::class, [
+       'default_protocol' => 'http',
+   ]);
+   ```
+
 FrameworkBundle
 ---------------
 
diff --git a/src/Symfony/Component/Form/CHANGELOG.md b/src/Symfony/Component/Form/CHANGELOG.md
@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+8.0
+---
+
+ * Change default value of `default_protocol` option in `UrlType` from `'http'` to `null`
+
 7.4
 ---
 
diff --git a/src/Symfony/Component/Form/Extension/Core/Type/UrlType.php b/src/Symfony/Component/Form/Extension/Core/Type/UrlType.php
@@ -39,11 +39,7 @@ public function buildView(FormView $view, FormInterface $form, array $options):
     public function configureOptions(OptionsResolver $resolver): void
     {
         $resolver->setDefaults([
-            'default_protocol' => static function (Options $options) {
-                trigger_deprecation('symfony/form', '7.1', 'Not configuring the "default_protocol" option when using the UrlType is deprecated. It will default to "null" in 8.0.');
-
-                return 'http';
-            },
+            'default_protocol' => null,
             'invalid_message' => 'Please enter a valid URL.',
         ]);
 
diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/Type/UrlTypeTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/Type/UrlTypeTest.php
@@ -11,30 +11,13 @@
 
 namespace Symfony\Component\Form\Tests\Extension\Core\Type;
 
-use Symfony\Bridge\PhpUnit\ExpectUserDeprecationMessageTrait;
 use Symfony\Component\Form\Extension\Core\Type\UrlType;
 use Symfony\Component\OptionsResolver\Exception\InvalidOptionsException;
 
 class UrlTypeTest extends TextTypeTest
 {
-    use ExpectUserDeprecationMessageTrait;
-
     public const TESTED_TYPE = UrlType::class;
 
-    /**
-     * @group legacy
-     */
-    public function testSubmitAddsDefaultProtocolIfNoneIsIncluded()
-    {
-        $this->expectUserDeprecationMessage('Since symfony/form 7.1: Not configuring the "default_protocol" option when using the UrlType is deprecated. It will default to "null" in 8.0.');
-        $form = $this->factory->create(static::TESTED_TYPE, 'name');
-
-        $form->submit('www.domain.com');
-
-        $this->assertSame('http://www.domain.com', $form->getData());
-        $this->assertSame('http://www.domain.com', $form->getViewData());
-    }
-
     public function testSubmitAddsNoDefaultProtocolIfAlreadyIncluded()
     {
         $form = $this->factory->create(static::TESTED_TYPE, null, [
@@ -107,6 +90,6 @@ public function testSubmitNullUsesDefaultEmptyData($emptyData = 'empty', $expect
 
     protected function getTestOptions(): array
     {
-        return ['default_protocol' => 'http'];
+        return [];
     }
 }
diff --git a/src/Symfony/Component/Form/Tests/Extension/Validator/Type/UrlTypeValidatorExtensionTest.php b/src/Symfony/Component/Form/Tests/Extension/Validator/Type/UrlTypeValidatorExtensionTest.php
@@ -20,7 +20,7 @@ class UrlTypeValidatorExtensionTest extends BaseValidatorExtensionTestCase
 
     protected function createForm(array $options = [])
     {
-        return $this->factory->create(UrlType::class, null, $options + ['default_protocol' => 'http']);
+        return $this->factory->create(UrlType::class, null, $options);
     }
 
     public function testInvalidMessage()

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ class UrlTypeValidatorExtensionTest extends BaseValidatorExtensionTestCase`
`20`	`20`
`21`	`21`	`protected function createForm(array $options = [])`
`22`	`22`	`{`
`23`		`- return $this->factory->create(UrlType::class, null, $options + ['default_protocol' => 'http']);`
	`23`	`+ return $this->factory->create(UrlType::class, null, $options);`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`public function testInvalidMessage()`