bug #18821 [2.3][Form] Removed UTC specification with timestamp (francisbesset)

nicolas-grekas · nicolas-grekas · commit 0cf017e568c7 · 2016-05-30T10:13:41.000+02:00
This PR was merged into the 2.3 branch. Discussion ---------- [2.3][Form] Removed UTC specification with timestamp | Q | A | ------------- | --- | Branch? | 2.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a The function `date_parse()` indicates a warning if a timezone is used with the timestamp: `Double timezone specification`. I removed the UTC specification and this time it's more faster! Commits ------- 0d14aac Removed UTC specification with timestamp
diff --git a/src/Symfony/Component/Form/Extension/Core/DataTransformer/DateTimeToLocalizedStringTransformer.php b/src/Symfony/Component/Form/Extension/Core/DataTransformer/DateTimeToLocalizedStringTransformer.php
@@ -126,7 +126,7 @@ public function reverseTransform($value)
 
         try {
             // read timestamp into DateTime object - the formatter delivers in UTC
-            $dateTime = new \DateTime(sprintf('@%s UTC', $timestamp));
+            $dateTime = new \DateTime(sprintf('@%s', $timestamp));
         } catch (\Exception $e) {
             throw new TransformationFailedException($e->getMessage(), $e->getCode(), $e);
         }

Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ public function reverseTransform($value)`
`126`	`126`
`127`	`127`	`try {`
`128`	`128`	`// read timestamp into DateTime object - the formatter delivers in UTC`
`129`		`- $dateTime = new \DateTime(sprintf('@%s UTC', $timestamp));`
	`129`	`+ $dateTime = new \DateTime(sprintf('@%s', $timestamp));`
`130`	`130`	`} catch (\Exception $e) {`
`131`	`131`	`throw new TransformationFailedException($e->getMessage(), $e->getCode(), $e);`
`132`	`132`	`}`