feature #52775 [HttpClient] Allow mocking start_time info in MockResponse (fancyweb)

fabpot · fabpot · commit 0d9562ff6cdd · 2023-12-13T08:55:16.000+01:00
This PR was merged into the 7.1 branch. Discussion ---------- [HttpClient] Allow mocking `start_time` info in `MockResponse` | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | - | License | MIT Let's honor the custom `start_time` passed to `MockResponse`. My use case is that the current behavior prevents me from easily testing code using this info. Commits ------- 7ace621 [HttpClient] Allow mocking start_time info in MockResponse
diff --git a/src/Symfony/Component/HttpClient/CHANGELOG.md b/src/Symfony/Component/HttpClient/CHANGELOG.md
@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+7.1
+---
+
+ * Allow mocking `start_time` info in `MockResponse`
+
 7.0
 ---
 
diff --git a/src/Symfony/Component/HttpClient/Response/MockResponse.php b/src/Symfony/Component/HttpClient/Response/MockResponse.php
@@ -217,6 +217,9 @@ private static function writeRequest(self $response, array $options, ResponseInt
     {
         $onProgress = $options['on_progress'] ?? static function () {};
         $response->info += $mock->getInfo() ?: [];
+        if (null !== $mock->getInfo('start_time')) {
+            $response->info['start_time'] = $mock->getInfo('start_time');
+        }
 
         // simulate "size_upload" if it is set
         if (isset($response->info['size_upload'])) {
diff --git a/src/Symfony/Component/HttpClient/Tests/MockHttpClientTest.php b/src/Symfony/Component/HttpClient/Tests/MockHttpClientTest.php
@@ -573,4 +573,14 @@ public function testMoreRequestsThanResponseFactoryResponses()
         $client->request('GET', 'https://example.com');
         $client->request('GET', 'https://example.com');
     }
+
+    public function testMockStartTimeInfo()
+    {
+        $client = new MockHttpClient(new MockResponse('foobarccc', [
+            'start_time' => 1701187598.313123,
+        ]));
+
+        $response = $client->request('GET', 'https://example.com');
+        $this->assertSame(1701187598.313123, $response->getInfo('start_time'));
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -217,6 +217,9 @@ private static function writeRequest(self $response, array $options, ResponseInt`
`217`	`217`	`{`
`218`	`218`	`$onProgress = $options['on_progress'] ?? static function () {};`
`219`	`219`	`$response->info += $mock->getInfo() ?: [];`
	`220`	`+ if (null !== $mock->getInfo('start_time')) {`
	`221`	`+ $response->info['start_time'] = $mock->getInfo('start_time');`
	`222`	`+ }`
`220`	`223`
`221`	`224`	`// simulate "size_upload" if it is set`
`222`	`225`	`if (isset($response->info['size_upload'])) {`