[VarExporter] LazyProxyTrait::__unserialize() should not be typehinted

nikophil · nikophil · commit 0f62950c1a7b · 2024-06-20T09:38:29.000+02:00
diff --git a/src/Symfony/Component/VarExporter/LazyProxyTrait.php b/src/Symfony/Component/VarExporter/LazyProxyTrait.php
@@ -309,7 +309,7 @@ public function __serialize(): array
         return $data;
     }
 
-    public function __unserialize(array $data): void
+    public function __unserialize($data): void
     {
         $class = self::class;
 
diff --git a/src/Symfony/Component/VarExporter/Tests/LazyProxyTraitTest.php b/src/Symfony/Component/VarExporter/Tests/LazyProxyTraitTest.php
@@ -298,6 +298,30 @@ public function testNormalization()
         $this->assertSame(['property' => 'property', 'method' => 'method'], $output);
     }
 
+    /**
+     * @dataProvider classWithUnserializeMagicMethodProvider
+     */
+    public function testItCanProxifyClassWithUnserializeMagicMethod(object $obj)
+    {
+        $proxy = $this->createLazyProxy($obj::class, fn () => $obj);
+        self::assertIsObject($proxy);
+    }
+
+    public static function classWithUnserializeMagicMethodProvider(): iterable
+    {
+        yield 'not type hinted __unserialize method' => [new class() {
+            public function __unserialize($array)
+            {
+            }
+        }];
+
+        yield 'type hinted __unserialize method' => [new class() {
+            public function __unserialize(array $array)
+            {
+            }
+        }];
+    }
+
     /**
      * @template T
      *

Original file line number	Diff line number	Diff line change
`@@ -309,7 +309,7 @@ public function __serialize(): array`
`309`	`309`	`return $data;`
`310`	`310`	`}`
`311`	`311`
`312`		`- public function __unserialize(array $data): void`
	`312`	`+ public function __unserialize($data): void`
`313`	`313`	`{`
`314`	`314`	`$class = self::class;`
`315`	`315`