minor #33490 [Bridge/Twig] use tty group on testLintDefaultPaths (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 108a7995127d · 2019-09-06T17:52:51.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [Bridge/Twig] use tty group on testLintDefaultPaths | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #33446 (comment) | License | MIT | Doc PR | - Note that I still think we should deprecate reading from STDIN when not explicitly asked for, as explained in #33446 (comment) Commits ------- 3c59bb5 [Bridge/Twig] use tty group on testLintDefaultPaths
diff --git a/.travis.yml b/.travis.yml
@@ -289,7 +289,7 @@ install:
               fi
 
               echo "$COMPONENTS" | parallel --gnu "tfold {} $PHPUNIT_X {}"
-              tfold src/Symfony/Component/Console.tty $PHPUNIT src/Symfony/Component/Console --group tty
+              tfold src/Symfony/Component/Console.tty $PHPUNIT --group tty
               if [[ $PHP = ${MIN_PHP%.*} ]]; then
                   export PHP=$MIN_PHP
                   tfold src/Symfony/Component/Process.sigchild SYMFONY_DEPRECATIONS_HELPER=weak php-$MIN_PHP/sapi/cli/php ./phpunit --colors=always src/Symfony/Component/Process/
diff --git a/src/Symfony/Bridge/Twig/Tests/Command/LintCommandTest.php b/src/Symfony/Bridge/Twig/Tests/Command/LintCommandTest.php
@@ -66,6 +66,9 @@ public function testLintFileCompileTimeException()
         $this->assertRegExp('/ERROR  in \S+ \(line /', trim($tester->getDisplay()));
     }
 
+    /**
+     * @group tty
+     */
     public function testLintDefaultPaths()
     {
         $tester = $this->createCommandTester();

Original file line number	Diff line number	Diff line change
`@@ -66,6 +66,9 @@ public function testLintFileCompileTimeException()`
`66`	`66`	`$this->assertRegExp('/ERROR in \S+ \(line /', trim($tester->getDisplay()));`
`67`	`67`	`}`
`68`	`68`
	`69`	`+ /**`
	`70`	`+ * @group tty`
	`71`	`+ */`
`69`	`72`	`public function testLintDefaultPaths()`
`70`	`73`	`{`
`71`	`74`	`$tester = $this->createCommandTester();`