[Cache] Handle serialization failures for Memcached

nicolas-grekas · nicolas-grekas · commit 12bd3c2e5ff6 · 2017-07-21T15:51:50.000+02:00
diff --git a/src/Symfony/Component/Cache/Traits/MemcachedTrait.php b/src/Symfony/Component/Cache/Traits/MemcachedTrait.php
@@ -26,6 +26,7 @@ trait MemcachedTrait
         'persistent_id' => null,
         'username' => null,
         'password' => null,
+        'serializer' => 'php',
     );
 
     private $client;
@@ -186,15 +187,32 @@ public static function createConnection($servers, array $options = array())
      */
     protected function doSave(array $values, $lifetime)
     {
-        return $this->checkResultCode($this->client->setMulti($values, $lifetime));
+        $serialized = array();
+        $failed = array();
+
+        foreach ($values as $id => $value) {
+            try {
+                $serialized[$id] = serialize($value);
+            } catch (\Exception $e) {
+                $failed[] = $id;
+            }
+        }
+
+        if (!$serialized) {
+            return $failed;
+        }
+
+        return $this->checkResultCode($this->client->setMulti($serialized, $lifetime)) ? $failed : false;
     }
 
     /**
      * {@inheritdoc}
      */
     protected function doFetch(array $ids)
     {
-        return $this->checkResultCode($this->client->getMulti($ids));
+        foreach ($this->checkResultCode($this->client->getMulti($ids)) as $id => $value) {
+            yield $id => parent::unserialize($value);
+        }
     }
 
     /**
