bug #46747 Fix global state pollution between tests run with ApplicationTester (Seldaek)

fabpot · fabpot · commit 12c6dbf4dbb2 · 2022-06-23T14:22:25.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- Fix global state pollution between tests run with ApplicationTester | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Tickets | Fix #...  | License | MIT | Doc PR | symfony/symfony-docs#...  If you run a test with ApplicationTester which includes -v or similar flag, then https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Console/Application.php#L985-L989 leaves the env in a dirty state, and all tests following also use -v. Commits ------- f4c81f1 Fix global state pollution between tests run with ApplicationTester
diff --git a/src/Symfony/Component/Console/Tester/ApplicationTester.php b/src/Symfony/Component/Console/Tester/ApplicationTester.php
@@ -54,17 +54,37 @@ public function __construct(Application $application)
      */
     public function run(array $input, $options = [])
     {
-        $this->input = new ArrayInput($input);
-        if (isset($options['interactive'])) {
-            $this->input->setInteractive($options['interactive']);
-        }
+        $prevShellVerbosity = getenv('SHELL_VERBOSITY');
 
-        if ($this->inputs) {
-            $this->input->setStream(self::createStream($this->inputs));
-        }
+        try {
+            $this->input = new ArrayInput($input);
+            if (isset($options['interactive'])) {
+                $this->input->setInteractive($options['interactive']);
+            }
 
-        $this->initOutput($options);
+            if ($this->inputs) {
+                $this->input->setStream(self::createStream($this->inputs));
+            }
 
-        return $this->statusCode = $this->application->run($this->input, $this->output);
+            $this->initOutput($options);
+
+            return $this->statusCode = $this->application->run($this->input, $this->output);
+        } finally {
+            // SHELL_VERBOSITY is set by Application::configureIO so we need to unset/reset it
+            // to its previous value to avoid one test's verbosity to spread to the following tests
+            if (false === $prevShellVerbosity) {
+                if (\function_exists('putenv')) {
+                    @putenv('SHELL_VERBOSITY');
+                }
+                unset($_ENV['SHELL_VERBOSITY']);
+                unset($_SERVER['SHELL_VERBOSITY']);
+            } else {
+                if (\function_exists('putenv')) {
+                    @putenv('SHELL_VERBOSITY='.$prevShellVerbosity);
+                }
+                $_ENV['SHELL_VERBOSITY'] = $prevShellVerbosity;
+                $_SERVER['SHELL_VERBOSITY'] = $prevShellVerbosity;
+            }
+        }
     }
 }
