minor #57798 [Console] be explicit about the signal to reset (xabbuh)

chalasr · chalasr · commit 169055a8a359 · 2024-07-22T15:10:56.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- [Console] be explicit about the signal to reset | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT Commits ------- 72f1f38 be explicit about the signal to reset
diff --git a/src/Symfony/Component/Console/Tests/ApplicationTest.php b/src/Symfony/Component/Console/Tests/ApplicationTest.php
@@ -71,12 +71,10 @@ protected function tearDown(): void
 
         if (\function_exists('pcntl_signal')) {
             // We reset all signals to their default value to avoid side effects
-            for ($i = 1; $i <= 15; ++$i) {
-                if (9 === $i) {
-                    continue;
-                }
-                pcntl_signal($i, \SIG_DFL);
-            }
+            pcntl_signal(\SIGINT, \SIG_DFL);
+            pcntl_signal(\SIGTERM, \SIG_DFL);
+            pcntl_signal(\SIGUSR1, \SIG_DFL);
+            pcntl_signal(\SIGUSR2, \SIG_DFL);
         }
     }
 
diff --git a/src/Symfony/Component/Console/Tests/ConsoleEventsTest.php b/src/Symfony/Component/Console/Tests/ConsoleEventsTest.php
@@ -35,12 +35,10 @@ protected function tearDown(): void
         if (\function_exists('pcntl_signal')) {
             pcntl_async_signals(false);
             // We reset all signals to their default value to avoid side effects
-            for ($i = 1; $i <= 15; ++$i) {
-                if (9 === $i) {
-                    continue;
-                }
-                pcntl_signal($i, \SIG_DFL);
-            }
+            pcntl_signal(\SIGINT, \SIG_DFL);
+            pcntl_signal(\SIGTERM, \SIG_DFL);
+            pcntl_signal(\SIGUSR1, \SIG_DFL);
+            pcntl_signal(\SIGUSR2, \SIG_DFL);
         }
     }
 
diff --git a/src/Symfony/Component/Console/Tests/SignalRegistry/SignalRegistryTest.php b/src/Symfony/Component/Console/Tests/SignalRegistry/SignalRegistryTest.php
@@ -23,12 +23,10 @@ protected function tearDown(): void
     {
         pcntl_async_signals(false);
         // We reset all signals to their default value to avoid side effects
-        for ($i = 1; $i <= 15; ++$i) {
-            if (9 === $i) {
-                continue;
-            }
-            pcntl_signal($i, \SIG_DFL);
-        }
+        pcntl_signal(\SIGINT, \SIG_DFL);
+        pcntl_signal(\SIGTERM, \SIG_DFL);
+        pcntl_signal(\SIGUSR1, \SIG_DFL);
+        pcntl_signal(\SIGUSR2, \SIG_DFL);
     }
 
     public function testOneCallbackForASignalSignalIsHandled()
