feature #49950 [Serializer] Marking some Normalizer classes as final (tucksaun)

fabpot · fabpot · commit 1f4a1bc8d90d · 2023-04-09T11:58:07.000+02:00
This PR was merged into the 6.3 branch. Discussion ---------- [Serializer] Marking some Normalizer classes as final | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | yes | Tickets | #49291 (review) | License | MIT | Doc PR | n/a As mentioned in #49291 (review). Making those classes final will allow to get rid of all the `__CLASS__ === static::class` for cacheability checks in 7.0 Commits ------- d976fc5 [Serializer] Marking some Normalizer classes as final
diff --git a/UPGRADE-6.3.md b/UPGRADE-6.3.md
@@ -117,4 +117,14 @@ Serializer
 
  * Deprecate `MissingConstructorArgumentsException` in favor of `MissingConstructorArgumentException`
  * Deprecate `CacheableSupportsMethodInterface` in favor of the new `getSupportedTypes(?string $format)` methods
- * The following Normalizer classes will become final in 7.0: `ObjectNormalizer`
+ * The following Normalizer classes will become final in 7.0:
+   * `ConstraintViolationListNormalizer`
+   * `CustomNormalizer`
+   * `DataUriNormalizer`
+   * `DateIntervalNormalizer`
+   * `DateTimeNormalizer`
+   * `DateTimeZoneNormalizer`
+   * `GetSetMethodNormalizer`
+   * `JsonSerializableNormalizer`
+   * `ObjectNormalizer`
+   * `PropertyNormalizer`
diff --git a/src/Symfony/Component/Serializer/CHANGELOG.md b/src/Symfony/Component/Serializer/CHANGELOG.md
@@ -10,7 +10,17 @@ CHANGELOG
  * Make `ProblemNormalizer` give details about `ValidationFailedException` and `PartialDenormalizationException`
  * Deprecate `MissingConstructorArgumentsException` in favor of `MissingConstructorArgumentException`
  * Deprecate `CacheableSupportsMethodInterface` in favor of the new `getSupportedTypes(?string $format)` methods
- * The following Normalizer classes will become final in 7.0: `ObjectNormalizer`
+ * The following Normalizer classes will become final in 7.0:
+   * `ConstraintViolationListNormalizer`
+   * `CustomNormalizer`
+   * `DataUriNormalizer`
+   * `DateIntervalNormalizer`
+   * `DateTimeNormalizer`
+   * `DateTimeZoneNormalizer`
+   * `GetSetMethodNormalizer`
+   * `JsonSerializableNormalizer`
+   * `ObjectNormalizer`
+   * `PropertyNormalizer`
 
 6.2
 ---
diff --git a/src/Symfony/Component/Serializer/Normalizer/ConstraintViolationListNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/ConstraintViolationListNormalizer.php
@@ -21,6 +21,8 @@
  *
  * @author Grégoire Pineau <lyrixx@lyrixx.info>
  * @author Kévin Dunglas <dunglas@gmail.com>
+ *
+ * @final since Symfony 6.3
  */
 class ConstraintViolationListNormalizer implements NormalizerInterface, CacheableSupportsMethodInterface
 {
diff --git a/src/Symfony/Component/Serializer/Normalizer/CustomNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/CustomNormalizer.php
@@ -16,6 +16,8 @@
 
 /**
  * @author Jordi Boggiano <j.boggiano@seld.be>
+ *
+ * @final since Symfony 6.3
  */
 class CustomNormalizer implements NormalizerInterface, DenormalizerInterface, SerializerAwareInterface, CacheableSupportsMethodInterface
 {
diff --git a/src/Symfony/Component/Serializer/Normalizer/DataUriNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/DataUriNormalizer.php
@@ -22,6 +22,8 @@
  * Denormalizes a data URI to a {@see \SplFileObject} object.
  *
  * @author Kévin Dunglas <dunglas@gmail.com>
+ *
+ * @final since Symfony 6.3
  */
 class DataUriNormalizer implements NormalizerInterface, DenormalizerInterface, CacheableSupportsMethodInterface
 {
diff --git a/src/Symfony/Component/Serializer/Normalizer/DateIntervalNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/DateIntervalNormalizer.php
@@ -19,6 +19,8 @@
  * Denormalizes an interval string to an instance of {@see \DateInterval}.
  *
  * @author Jérôme Parmentier <jerome@prmntr.me>
+ *
+ * @final since Symfony 6.3
  */
 class DateIntervalNormalizer implements NormalizerInterface, DenormalizerInterface, CacheableSupportsMethodInterface
 {
diff --git a/src/Symfony/Component/Serializer/Normalizer/DateTimeNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/DateTimeNormalizer.php
@@ -20,6 +20,8 @@
  * Denormalizes a date string to an instance of {@see \DateTime} or {@see \DateTimeImmutable}.
  *
  * @author Kévin Dunglas <dunglas@gmail.com>
+ *
+ * @final since Symfony 6.3
  */
 class DateTimeNormalizer implements NormalizerInterface, DenormalizerInterface, CacheableSupportsMethodInterface
 {
diff --git a/src/Symfony/Component/Serializer/Normalizer/DateTimeZoneNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/DateTimeZoneNormalizer.php
@@ -19,6 +19,8 @@
  * Normalizes a {@see \DateTimeZone} object to a timezone string.
  *
  * @author Jérôme Desjardins <jewome62@gmail.com>
+ *
+ * @final since Symfony 6.3
  */
 class DateTimeZoneNormalizer implements NormalizerInterface, DenormalizerInterface, CacheableSupportsMethodInterface
 {
diff --git a/src/Symfony/Component/Serializer/Normalizer/GetSetMethodNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/GetSetMethodNormalizer.php
@@ -33,6 +33,8 @@
  *
  * @author Nils Adermann <naderman@naderman.de>
  * @author Kévin Dunglas <dunglas@gmail.com>
+ *
+ * @final since Symfony 6.3
  */
 class GetSetMethodNormalizer extends AbstractObjectNormalizer
 {
diff --git a/src/Symfony/Component/Serializer/Normalizer/JsonSerializableNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/JsonSerializableNormalizer.php
@@ -18,6 +18,8 @@
  * A normalizer that uses an objects own JsonSerializable implementation.
  *
  * @author Fred Cox <mcfedr@gmail.com>
+ *
+ * @final since Symfony 6.3
  */
 class JsonSerializableNormalizer extends AbstractNormalizer
 {
diff --git a/src/Symfony/Component/Serializer/Normalizer/PropertyNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/PropertyNormalizer.php
@@ -33,6 +33,8 @@
  *
  * @author Matthieu Napoli <matthieu@mnapoli.fr>
  * @author Kévin Dunglas <dunglas@gmail.com>
+ *
+ * @final since Symfony 6.3
  */
 class PropertyNormalizer extends AbstractObjectNormalizer
 {

Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,8 @@`
`21`	`21`	`*`
`22`	`22`	`* @author Grégoire Pineau <lyrixx@lyrixx.info>`
`23`	`23`	`* @author Kévin Dunglas <dunglas@gmail.com>`
	`24`	`+ *`
	`25`	`+ * @final since Symfony 6.3`
`24`	`26`	`*/`
`25`	`27`	`class ConstraintViolationListNormalizer implements NormalizerInterface, CacheableSupportsMethodInterface`
`26`	`28`	`{`
Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,8 @@`
`16`	`16`
`17`	`17`	`/**`
`18`	`18`	`* @author Jordi Boggiano <j.boggiano@seld.be>`
	`19`	`+ *`
	`20`	`+ * @final since Symfony 6.3`
`19`	`21`	`*/`
`20`	`22`	`class CustomNormalizer implements NormalizerInterface, DenormalizerInterface, SerializerAwareInterface, CacheableSupportsMethodInterface`
`21`	`23`	`{`
Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,8 @@`
`22`	`22`	`* Denormalizes a data URI to a {@see \SplFileObject} object.`
`23`	`23`	`*`
`24`	`24`	`* @author Kévin Dunglas <dunglas@gmail.com>`
	`25`	`+ *`
	`26`	`+ * @final since Symfony 6.3`
`25`	`27`	`*/`
`26`	`28`	`class DataUriNormalizer implements NormalizerInterface, DenormalizerInterface, CacheableSupportsMethodInterface`
`27`	`29`	`{`
Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,8 @@`
`19`	`19`	`* Denormalizes an interval string to an instance of {@see \DateInterval}.`
`20`	`20`	`*`
`21`	`21`	`* @author Jérôme Parmentier <jerome@prmntr.me>`
	`22`	`+ *`
	`23`	`+ * @final since Symfony 6.3`
`22`	`24`	`*/`
`23`	`25`	`class DateIntervalNormalizer implements NormalizerInterface, DenormalizerInterface, CacheableSupportsMethodInterface`
`24`	`26`	`{`
Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,8 @@`
`20`	`20`	`* Denormalizes a date string to an instance of {@see \DateTime} or {@see \DateTimeImmutable}.`
`21`	`21`	`*`
`22`	`22`	`* @author Kévin Dunglas <dunglas@gmail.com>`
	`23`	`+ *`
	`24`	`+ * @final since Symfony 6.3`
`23`	`25`	`*/`
`24`	`26`	`class DateTimeNormalizer implements NormalizerInterface, DenormalizerInterface, CacheableSupportsMethodInterface`
`25`	`27`	`{`
Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,8 @@`
`33`	`33`	`*`
`34`	`34`	`* @author Nils Adermann <naderman@naderman.de>`
`35`	`35`	`* @author Kévin Dunglas <dunglas@gmail.com>`
	`36`	`+ *`
	`37`	`+ * @final since Symfony 6.3`
`36`	`38`	`*/`
`37`	`39`	`class GetSetMethodNormalizer extends AbstractObjectNormalizer`
`38`	`40`	`{`
Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,8 @@`
`18`	`18`	`* A normalizer that uses an objects own JsonSerializable implementation.`
`19`	`19`	`*`
`20`	`20`	`* @author Fred Cox <mcfedr@gmail.com>`
	`21`	`+ *`
	`22`	`+ * @final since Symfony 6.3`
`21`	`23`	`*/`
`22`	`24`	`class JsonSerializableNormalizer extends AbstractNormalizer`
`23`	`25`	`{`