[Serializer] ObjectNormalizer: don't serialize static methods and props

dunglas · fabpot · commit 1fab27b58cd9 · 2015-11-17T20:34:27.000+01:00
diff --git a/src/Symfony/Component/Serializer/Normalizer/ObjectNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/ObjectNormalizer.php
@@ -68,6 +68,7 @@ public function normalize($object, $format = null, array $context = array())
             $reflClass = new \ReflectionClass($object);
             foreach ($reflClass->getMethods(\ReflectionMethod::IS_PUBLIC) as $reflMethod) {
                 if (
+                    !$reflMethod->isStatic() &&
                     !$reflMethod->isConstructor() &&
                     !$reflMethod->isDestructor() &&
                     0 === $reflMethod->getNumberOfRequiredParameters()
@@ -86,7 +87,9 @@ public function normalize($object, $format = null, array $context = array())
 
             // properties
             foreach ($reflClass->getProperties(\ReflectionProperty::IS_PUBLIC) as $reflProperty) {
-                $attributes[$reflProperty->getName()] = true;
+                if (!$reflProperty->isStatic()) {
+                    $attributes[$reflProperty->getName()] = true;
+                }
             }
 
             $attributes = array_keys($attributes);
diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php b/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php
@@ -456,6 +456,11 @@ public function testNoTraversableSupport()
     {
         $this->assertFalse($this->normalizer->supportsNormalization(new \ArrayObject()));
     }
+
+    public function testNormalizeStatic()
+    {
+        $this->assertEquals(array('foo' => 'K'), $this->normalizer->normalize(new ObjectWithStaticPropertiesAndMethods()));
+    }
 }
 
 class ObjectDummy
@@ -605,3 +610,14 @@ public function otherMethod()
         throw new \RuntimeException('Dummy::otherMethod() should not be called');
     }
 }
+
+class ObjectWithStaticPropertiesAndMethods
+{
+    public $foo = 'K';
+    public static $bar = 'A';
+
+    public static function getBaz()
+    {
+        return 'L';
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -456,6 +456,11 @@ public function testNoTraversableSupport()`
`456`	`456`	`{`
`457`	`457`	`$this->assertFalse($this->normalizer->supportsNormalization(new \ArrayObject()));`
`458`	`458`	`}`
	`459`	`+`
	`460`	`+ public function testNormalizeStatic()`
	`461`	`+ {`
	`462`	`+ $this->assertEquals(array('foo' => 'K'), $this->normalizer->normalize(new ObjectWithStaticPropertiesAndMethods()));`
	`463`	`+ }`
`459`	`464`	`}`
`460`	`465`
`461`	`466`	`class ObjectDummy`
`@@ -605,3 +610,14 @@ public function otherMethod()`
`605`	`610`	`throw new \RuntimeException('Dummy::otherMethod() should not be called');`
`606`	`611`	`}`
`607`	`612`	`}`
	`613`	`+`
	`614`	`+class ObjectWithStaticPropertiesAndMethods`
	`615`	`+{`
	`616`	`+ public $foo = 'K';`
	`617`	`+ public static $bar = 'A';`
	`618`	`+`
	`619`	`+ public static function getBaz()`
	`620`	`+ {`
	`621`	`+ return 'L';`
	`622`	`+ }`
	`623`	`+}`