minor #20104 [TwigBundle] Adjust CacheWarmingTest for TemplateCacheWarmer introduced in 2.8 (tucksaun)

fabpot · fabpot · commit 2081bd924829 · 2016-09-30T07:47:16.000-07:00
This PR was merged into the 2.8 branch. Discussion ---------- [TwigBundle] Adjust CacheWarmingTest for TemplateCacheWarmer introduced in 2.8 | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - With #20103, issue reported in #20065 is fixed, however it will now break in 2.8+ as another cache warmer has been introduced with #16271. Commits ------- 360ca48 [TwigBundle] Adjust CacheWarmingTest for TemplateCacheWarmer introduced in 2.8
diff --git a/src/Symfony/Bundle/TwigBundle/Tests/Functional/CacheWarmingTest.php b/src/Symfony/Bundle/TwigBundle/Tests/Functional/CacheWarmingTest.php
@@ -31,7 +31,7 @@ public function testCacheIsProperlyWarmedWhenTemplatingIsAvailable()
         $this->assertTrue(file_exists($kernel->getCacheDir().'/twig'));
     }
 
-    public function testCacheIsNotWarmedWhenTemplatingIsDisabled()
+    public function testCacheIsProperlyWarmedWhenTemplatingIsDisabled()
     {
         $kernel = new CacheWarmingKernel(false);
         $kernel->boot();
@@ -40,7 +40,7 @@ public function testCacheIsNotWarmedWhenTemplatingIsDisabled()
         $warmer->enableOptionalWarmers();
         $warmer->warmUp($kernel->getCacheDir());
 
-        $this->assertFalse(file_exists($kernel->getCacheDir().'/twig'));
+        $this->assertTrue(file_exists($kernel->getCacheDir().'/twig'));
     }
 
     protected function setUp()

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ public function testCacheIsProperlyWarmedWhenTemplatingIsAvailable()`
`31`	`31`	`$this->assertTrue(file_exists($kernel->getCacheDir().'/twig'));`
`32`	`32`	`}`
`33`	`33`
`34`		`- public function testCacheIsNotWarmedWhenTemplatingIsDisabled()`
	`34`	`+ public function testCacheIsProperlyWarmedWhenTemplatingIsDisabled()`
`35`	`35`	`{`
`36`	`36`	`$kernel = new CacheWarmingKernel(false);`
`37`	`37`	`$kernel->boot();`
`@@ -40,7 +40,7 @@ public function testCacheIsNotWarmedWhenTemplatingIsDisabled()`
`40`	`40`	`$warmer->enableOptionalWarmers();`
`41`	`41`	`$warmer->warmUp($kernel->getCacheDir());`
`42`	`42`
`43`		`- $this->assertFalse(file_exists($kernel->getCacheDir().'/twig'));`
	`43`	`+ $this->assertTrue(file_exists($kernel->getCacheDir().'/twig'));`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`protected function setUp()`