Deprecate XML configuration format

MatTheCat · MatTheCat · commit 2169ea4d282c · 2025-05-28T10:25:52.000+02:00
diff --git a/UPGRADE-7.4.md b/UPGRADE-7.4.md
@@ -0,0 +1,29 @@
+UPGRADE FROM 7.3 to 7.4
+=======================
+
+Symfony 7.4 is a minor release. According to the Symfony release process, there should be no significant
+backward compatibility breaks. Minor backward compatibility breaks are prefixed in this document with
+`[BC BREAK]`, make sure your code is compatible with these entries before upgrading.
+Read more about this in the [Symfony documentation](https://symfony.com/doc/7.4/setup/upgrade_minor.html).
+
+If you're upgrading from a version below 7.3, follow the [7.3 upgrade guide](UPGRADE-7.3.md) first.
+
+DependencyInjection
+-------------------
+
+ * Deprecate XML configuration format, use YAML or PHP instead
+
+Routing
+-------
+
+ * Deprecate XML configuration format, use YAML, PHP or attributes instead
+
+Serializer
+----------
+
+ * Deprecate XML configuration format, use YAML or attributes instead
+
+Validator
+---------
+
+ * Deprecate XML configuration format, use YAML or attributes instead
diff --git a/src/Symfony/Component/DependencyInjection/CHANGELOG.md b/src/Symfony/Component/DependencyInjection/CHANGELOG.md
@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+7.4
+---
+
+ * Deprecate XML configuration format, use YAML or PHP instead
+
 7.3
 ---
 
diff --git a/src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php b/src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php
@@ -34,6 +34,8 @@
  * XmlFileLoader loads XML files service definitions.
  *
  * @author Fabien Potencier <fabien@symfony.com>
+ *
+ * @deprecated since Symfony 7.4, use another loader instead
  */
 class XmlFileLoader extends FileLoader
 {
@@ -43,6 +45,8 @@ class XmlFileLoader extends FileLoader
 
     public function load(mixed $resource, ?string $type = null): mixed
     {
+        trigger_deprecation('symfony/dependency-injection', '7.4', 'XML configuration format is deprecated, use YAML or PHP instead.');
+
         $path = $this->locator->locate($resource);
 
         $xml = $this->parseFileToDOM($path);
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php b/src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php
@@ -15,6 +15,7 @@
 use Psr\Log\LoggerInterface;
 use Psr\Log\NullLogger;
 use Symfony\Bridge\PhpUnit\ClassExistsMock;
+use Symfony\Bridge\PhpUnit\ExpectUserDeprecationMessageTrait;
 use Symfony\Component\Config\FileLocator;
 use Symfony\Component\Config\Resource\ClassExistenceResource;
 use Symfony\Component\DependencyInjection\Argument\ServiceLocatorArgument;
@@ -44,6 +45,8 @@
 
 class AutowirePassTest extends TestCase
 {
+    use ExpectUserDeprecationMessageTrait;
+
     public static function setUpBeforeClass(): void
     {
         ClassExistsMock::register(AutowirePass::class);
@@ -989,8 +992,13 @@ public function testExceptionWhenAliasDoesNotExist()
         }
     }
 
+    /**
+     * @group legacy
+     */
     public function testInlineServicesAreNotCandidates()
     {
+        $this->expectUserDeprecationMessage('Since symfony/dependency-injection 7.4: XML configuration format is deprecated, use YAML or PHP instead.');
+
         $container = new ContainerBuilder();
         $loader = new XmlFileLoader($container, new FileLocator(realpath(__DIR__.'/../Fixtures/xml')));
         $loader->load('services_inline_not_candidate.xml');
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Loader/XmlFileLoaderTest.php b/src/Symfony/Component/DependencyInjection/Tests/Loader/XmlFileLoaderTest.php
@@ -50,6 +50,9 @@
 use Symfony\Component\DependencyInjection\Tests\Fixtures\RemoteCallerSocket;
 use Symfony\Component\ExpressionLanguage\Expression;
 
+/**
+ * @group legacy
+ */
 class XmlFileLoaderTest extends TestCase
 {
     use ExpectUserDeprecationMessageTrait;
@@ -1335,9 +1338,6 @@ public function testUnknownConstantAsKey()
         $loader->load('key_type_wrong_constant.xml');
     }
 
-    /**
-     * @group legacy
-     */
     public function testDeprecatedTagged()
     {
         $container = new ContainerBuilder();
diff --git a/src/Symfony/Component/Routing/CHANGELOG.md b/src/Symfony/Component/Routing/CHANGELOG.md
@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+7.4
+---
+
+ * Deprecate XML configuration format, use YAML, PHP or attributes instead
+
 7.3
 ---
 
diff --git a/src/Symfony/Component/Routing/Loader/XmlFileLoader.php b/src/Symfony/Component/Routing/Loader/XmlFileLoader.php
@@ -24,6 +24,8 @@
  *
  * @author Fabien Potencier <fabien@symfony.com>
  * @author Tobias Schultze <http://tobion.de>
+ *
+ * @deprecated since Symfony 7.4, use another loader instead
  */
 class XmlFileLoader extends FileLoader
 {
@@ -40,6 +42,8 @@ class XmlFileLoader extends FileLoader
      */
     public function load(mixed $file, ?string $type = null): RouteCollection
     {
+        trigger_deprecation('symfony/routing', '7.4', 'XML configuration format is deprecated, use YAML, PHP or attributes instead.');
+
         $path = $this->locator->locate($file);
 
         $xml = $this->loadFile($path);
diff --git a/src/Symfony/Component/Routing/Tests/Loader/XmlFileLoaderTest.php b/src/Symfony/Component/Routing/Tests/Loader/XmlFileLoaderTest.php
@@ -23,6 +23,9 @@
 use Symfony\Component\Routing\Tests\Fixtures\CustomXmlFileLoader;
 use Symfony\Component\Routing\Tests\Fixtures\Psr4Controllers\MyController;
 
+/**
+ * @group legacy
+ */
 class XmlFileLoaderTest extends TestCase
 {
     public function testSupports()
diff --git a/src/Symfony/Component/Serializer/CHANGELOG.md b/src/Symfony/Component/Serializer/CHANGELOG.md
@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+7.4
+---
+
+ * Deprecate XML configuration format, use YAML or attributes instead
+
 7.3
 ---
 
diff --git a/src/Symfony/Component/Serializer/Mapping/Loader/XmlFileLoader.php b/src/Symfony/Component/Serializer/Mapping/Loader/XmlFileLoader.php
@@ -23,6 +23,8 @@
  * Loads XML mapping files.
  *
  * @author Kévin Dunglas <dunglas@gmail.com>
+ *
+ * @deprecated since Symfony 7.4, use another loader instead
  */
 class XmlFileLoader extends FileLoader
 {
@@ -35,6 +37,8 @@ class XmlFileLoader extends FileLoader
 
     public function loadClassMetadata(ClassMetadataInterface $classMetadata): bool
     {
+        trigger_deprecation('symfony/serializer', '7.4', 'XML configuration format is deprecated, use YAML or attributes instead.');
+
         if (!$this->classes ??= $this->getClassesFromXml()) {
             return false;
         }
diff --git a/src/Symfony/Component/Serializer/Tests/Mapping/Loader/XmlFileLoaderTest.php b/src/Symfony/Component/Serializer/Tests/Mapping/Loader/XmlFileLoaderTest.php
@@ -31,6 +31,8 @@
 
 /**
  * @author Kévin Dunglas <dunglas@gmail.com>
+ *
+ * @group legacy
  */
 class XmlFileLoaderTest extends TestCase
 {
diff --git a/src/Symfony/Component/Validator/CHANGELOG.md b/src/Symfony/Component/Validator/CHANGELOG.md
@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+7.4
+---
+
+ * Deprecate XML configuration format, use YAML or attributes instead
+
 7.3
 ---
 
diff --git a/src/Symfony/Component/Validator/Mapping/Loader/XmlFileLoader.php b/src/Symfony/Component/Validator/Mapping/Loader/XmlFileLoader.php
@@ -20,6 +20,8 @@
  * Loads validation metadata from an XML file.
  *
  * @author Bernhard Schussek <bschussek@gmail.com>
+ *
+ * @deprecated since Symfony 7.4, use another loader instead
  */
 class XmlFileLoader extends FileLoader
 {
@@ -37,6 +39,8 @@ public function __construct(string $file)
 
     public function loadClassMetadata(ClassMetadata $metadata): bool
     {
+        trigger_deprecation('symfony/validator', '7.4', 'XML configuration format is deprecated, use YAML or attributes instead.');
+
         if (!isset($this->classes)) {
             $this->loadClassesFromXml();
         }
diff --git a/src/Symfony/Component/Validator/Mapping/Loader/XmlFilesLoader.php b/src/Symfony/Component/Validator/Mapping/Loader/XmlFilesLoader.php
@@ -11,13 +11,17 @@
 
 namespace Symfony\Component\Validator\Mapping\Loader;
 
+trigger_deprecation('symfony/validator', '7.4', 'XML configuration format is deprecated, use YAML or attributes instead.');
+
 /**
  * Loads validation metadata from a list of XML files.
  *
  * @author Bulat Shakirzyanov <mallluhuct@gmail.com>
  * @author Bernhard Schussek <bschussek@gmail.com>
  *
  * @see FilesLoader
+ *
+ * @deprecated since Symfony 7.4, use another loader instead
  */
 class XmlFilesLoader extends FilesLoader
 {
diff --git a/src/Symfony/Component/Validator/Tests/Mapping/Loader/XmlFileLoaderTest.php b/src/Symfony/Component/Validator/Tests/Mapping/Loader/XmlFileLoaderTest.php
@@ -37,6 +37,9 @@
 use Symfony\Component\Validator\Tests\Mapping\Loader\Fixtures\ConstraintWithNamedArguments;
 use Symfony\Component\Validator\Tests\Mapping\Loader\Fixtures\ConstraintWithoutValueWithNamedArguments;
 
+/**
+ * @group legacy
+ */
 class XmlFileLoaderTest extends TestCase
 {
     use ExpectUserDeprecationMessageTrait;

Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,8 @@`
`34`	`34`	`* XmlFileLoader loads XML files service definitions.`
`35`	`35`	`*`
`36`	`36`	`* @author Fabien Potencier <fabien@symfony.com>`
	`37`	`+ *`
	`38`	`+ * @deprecated since Symfony 7.4, use another loader instead`
`37`	`39`	`*/`
`38`	`40`	`class XmlFileLoader extends FileLoader`
`39`	`41`	`{`
`@@ -43,6 +45,8 @@ class XmlFileLoader extends FileLoader`
`43`	`45`
`44`	`46`	`public function load(mixed $resource, ?string $type = null): mixed`
`45`	`47`	`{`
	`48`	`+ trigger_deprecation('symfony/dependency-injection', '7.4', 'XML configuration format is deprecated, use YAML or PHP instead.');`
	`49`	`+`
`46`	`50`	`$path = $this->locator->locate($resource);`
`47`	`51`
`48`	`52`	`$xml = $this->parseFileToDOM($path);`
Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,7 @@`
`15`	`15`	`use Psr\Log\LoggerInterface;`
`16`	`16`	`use Psr\Log\NullLogger;`
`17`	`17`	`use Symfony\Bridge\PhpUnit\ClassExistsMock;`
	`18`	`+use Symfony\Bridge\PhpUnit\ExpectUserDeprecationMessageTrait;`
`18`	`19`	`use Symfony\Component\Config\FileLocator;`
`19`	`20`	`use Symfony\Component\Config\Resource\ClassExistenceResource;`
`20`	`21`	`use Symfony\Component\DependencyInjection\Argument\ServiceLocatorArgument;`
`@@ -44,6 +45,8 @@`
`44`	`45`
`45`	`46`	`class AutowirePassTest extends TestCase`
`46`	`47`	`{`
	`48`	`+ use ExpectUserDeprecationMessageTrait;`
	`49`	`+`
`47`	`50`	`public static function setUpBeforeClass(): void`
`48`	`51`	`{`
`49`	`52`	`ClassExistsMock::register(AutowirePass::class);`
`@@ -989,8 +992,13 @@ public function testExceptionWhenAliasDoesNotExist()`
`989`	`992`	`}`
`990`	`993`	`}`
`991`	`994`
	`995`	`+ /**`
	`996`	`+ * @group legacy`
	`997`	`+ */`
`992`	`998`	`public function testInlineServicesAreNotCandidates()`
`993`	`999`	`{`
	`1000`	`+ $this->expectUserDeprecationMessage('Since symfony/dependency-injection 7.4: XML configuration format is deprecated, use YAML or PHP instead.');`
	`1001`	`+`
`994`	`1002`	`$container = new ContainerBuilder();`
`995`	`1003`	`$loader = new XmlFileLoader($container, new FileLocator(realpath(__DIR__.'/../Fixtures/xml')));`
`996`	`1004`	`$loader->load('services_inline_not_candidate.xml');`
Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,9 @@`
`50`	`50`	`use Symfony\Component\DependencyInjection\Tests\Fixtures\RemoteCallerSocket;`
`51`	`51`	`use Symfony\Component\ExpressionLanguage\Expression;`
`52`	`52`
	`53`	`+/**`
	`54`	`+ * @group legacy`
	`55`	`+ */`
`53`	`56`	`class XmlFileLoaderTest extends TestCase`
`54`	`57`	`{`
`55`	`58`	`use ExpectUserDeprecationMessageTrait;`
`@@ -1335,9 +1338,6 @@ public function testUnknownConstantAsKey()`
`1335`	`1338`	`$loader->load('key_type_wrong_constant.xml');`
`1336`	`1339`	`}`
`1337`	`1340`
`1338`		`- /**`
`1339`		`- * @group legacy`
`1340`		`- */`
`1341`	`1341`	`public function testDeprecatedTagged()`
`1342`	`1342`	`{`
`1343`	`1343`	`$container = new ContainerBuilder();`
Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,8 @@`
`24`	`24`	`*`
`25`	`25`	`* @author Fabien Potencier <fabien@symfony.com>`
`26`	`26`	`* @author Tobias Schultze <http://tobion.de>`
	`27`	`+ *`
	`28`	`+ * @deprecated since Symfony 7.4, use another loader instead`
`27`	`29`	`*/`
`28`	`30`	`class XmlFileLoader extends FileLoader`
`29`	`31`	`{`
`@@ -40,6 +42,8 @@ class XmlFileLoader extends FileLoader`
`40`	`42`	`*/`
`41`	`43`	`public function load(mixed $file, ?string $type = null): RouteCollection`
`42`	`44`	`{`
	`45`	`+ trigger_deprecation('symfony/routing', '7.4', 'XML configuration format is deprecated, use YAML, PHP or attributes instead.');`
	`46`	`+`
`43`	`47`	`$path = $this->locator->locate($file);`
`44`	`48`
`45`	`49`	`$xml = $this->loadFile($path);`
Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,9 @@`
`23`	`23`	`use Symfony\Component\Routing\Tests\Fixtures\CustomXmlFileLoader;`
`24`	`24`	`use Symfony\Component\Routing\Tests\Fixtures\Psr4Controllers\MyController;`
`25`	`25`
	`26`	`+/**`
	`27`	`+ * @group legacy`
	`28`	`+ */`
`26`	`29`	`class XmlFileLoaderTest extends TestCase`
`27`	`30`	`{`
`28`	`31`	`public function testSupports()`
Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,8 @@`
`23`	`23`	`* Loads XML mapping files.`
`24`	`24`	`*`
`25`	`25`	`* @author Kévin Dunglas <dunglas@gmail.com>`
	`26`	`+ *`
	`27`	`+ * @deprecated since Symfony 7.4, use another loader instead`
`26`	`28`	`*/`
`27`	`29`	`class XmlFileLoader extends FileLoader`
`28`	`30`	`{`
`@@ -35,6 +37,8 @@ class XmlFileLoader extends FileLoader`
`35`	`37`
`36`	`38`	`public function loadClassMetadata(ClassMetadataInterface $classMetadata): bool`
`37`	`39`	`{`
	`40`	`+ trigger_deprecation('symfony/serializer', '7.4', 'XML configuration format is deprecated, use YAML or attributes instead.');`
	`41`	`+`
`38`	`42`	`if (!$this->classes ??= $this->getClassesFromXml()) {`
`39`	`43`	`return false;`
`40`	`44`	`}`