feature #61180 [HttpFoundation] Trigger PHP warning when using Request::sendHeaders() after headers have already been sent (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 265d4b2fc892 · 2025-07-21T14:40:22.000+02:00
This PR was merged into the 8.0 branch. Discussion ---------- [HttpFoundation] Trigger PHP warning when using `Request::sendHeaders()` after headers have already been sent | Q | A | ------------- | --- | Branch? | 8.0 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | - | License | MIT Commits ------- 1c64caa [HttpFoundation] Trigger PHP warning when using `Request::sendHeaders()` after headers have already been sent
diff --git a/UPGRADE-8.0.md b/UPGRADE-8.0.md
@@ -219,6 +219,7 @@ HttpFoundation
 --------------
 
  * Remove the following deprecated session options from `NativeSessionStorage`: `referer_check`, `use_only_cookies`, `use_trans_sid`, `sid_length`, `sid_bits_per_character`, `trans_sid_hosts`, `trans_sid_tags`
+ * Trigger PHP warning when using `Request::sendHeaders()` after headers have already been sent; use a `StreamedResponse` instead
 
 HttpClient
 ----------
diff --git a/src/Symfony/Component/HttpFoundation/CHANGELOG.md b/src/Symfony/Component/HttpFoundation/CHANGELOG.md
@@ -5,6 +5,7 @@ CHANGELOG
 ---
 
  * Remove the following deprecated session options from `NativeSessionStorage`: `referer_check`, `use_only_cookies`, `use_trans_sid`, `sid_length`, `sid_bits_per_character`, `trans_sid_hosts`, `trans_sid_tags`
+ * Trigger PHP warning when using `Request::sendHeaders()` after headers have already been sent; use a `StreamedResponse` instead
 
 7.4
 ---
diff --git a/src/Symfony/Component/HttpFoundation/Response.php b/src/Symfony/Component/HttpFoundation/Response.php
@@ -319,8 +319,7 @@ public function sendHeaders(?int $statusCode = null): static
         if (headers_sent()) {
             if (!\in_array(\PHP_SAPI, ['cli', 'phpdbg', 'embed'], true)) {
                 $statusCode ??= $this->statusCode;
-                trigger_deprecation('symfony/http-foundation', '7.4', 'Trying to use "%s::sendHeaders()" after headers have already been sent is deprecated will throw a PHP warning in 8.0. Use a "StreamedResponse" instead.', static::class);
-                // header(\sprintf('HTTP/%s %s %s', $this->version, $statusCode, $this->statusText), true, $statusCode);
+                header(\sprintf('HTTP/%s %s %s', $this->version, $statusCode, $this->statusText), true, $statusCode);
             }
 
             return $this;
diff --git a/src/Symfony/Component/HttpFoundation/composer.json b/src/Symfony/Component/HttpFoundation/composer.json
@@ -17,7 +17,6 @@
     ],
     "require": {
         "php": ">=8.4",
-        "symfony/deprecation-contracts": "^2.5|^3.0",
         "symfony/polyfill-mbstring": "^1.1"
     },
     "require-dev": {

Original file line number	Diff line number	Diff line change
`@@ -319,8 +319,7 @@ public function sendHeaders(?int $statusCode = null): static`
`319`	`319`	`if (headers_sent()) {`
`320`	`320`	`if (!\in_array(\PHP_SAPI, ['cli', 'phpdbg', 'embed'], true)) {`
`321`	`321`	`$statusCode ??= $this->statusCode;`
`322`		`- trigger_deprecation('symfony/http-foundation', '7.4', 'Trying to use "%s::sendHeaders()" after headers have already been sent is deprecated will throw a PHP warning in 8.0. Use a "StreamedResponse" instead.', static::class);`
`323`		`- // header(\sprintf('HTTP/%s %s %s', $this->version, $statusCode, $this->statusText), true, $statusCode);`
	`322`	`+ header(\sprintf('HTTP/%s %s %s', $this->version, $statusCode, $this->statusText), true, $statusCode);`
`324`	`323`	`}`
`325`	`324`
`326`	`325`	`return $this;`