Use explode instead of preg_split because no need of regex

natepage · natepage · commit 2737f35d7c09 · 2019-11-22T01:28:13.000+11:00
diff --git a/src/Symfony/Component/Yaml/Dumper.php b/src/Symfony/Component/Yaml/Dumper.php
@@ -105,7 +105,7 @@ public function dump($input, $inline = 0, $indent = 0, $flags = 0)
                     $blockIndentationIndicator = (' ' === substr($value, 0, 1)) ? (string) $this->indentation : '';
                     $output .= sprintf("%s%s%s |%s\n", $prefix, $dumpAsMap ? Inline::dump($key, $flags).':' : '-', '', $blockIndentationIndicator);
 
-                    foreach (preg_split('/\n/', $value) as $row) {
+                    foreach (explode("\n", $value) as $row) {
                         $output .= sprintf("%s%s%s\n", $prefix, str_repeat(' ', $this->indentation), $row);
                     }
 
@@ -121,7 +121,7 @@ public function dump($input, $inline = 0, $indent = 0, $flags = 0)
                         $blockIndentationIndicator = (' ' === substr($value->getValue(), 0, 1)) ? (string) $this->indentation : '';
                         $output .= sprintf(" |%s\n", $blockIndentationIndicator);
 
-                        foreach (preg_split('/\n/', $value->getValue()) as $row) {
+                        foreach (explode("\n", $value->getValue()) as $row) {
                             $output .= sprintf("%s%s%s\n", $prefix, str_repeat(' ', $this->indentation), $row);
                         }
 

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,7 @@ public function dump($input, $inline = 0, $indent = 0, $flags = 0)`
`105`	`105`	`$blockIndentationIndicator = (' ' === substr($value, 0, 1)) ? (string) $this->indentation : '';`
`106`	`106`	`$output .= sprintf("%s%s%s \|%s\n", $prefix, $dumpAsMap ? Inline::dump($key, $flags).':' : '-', '', $blockIndentationIndicator);`
`107`	`107`
`108`		`- foreach (preg_split('/\n/', $value) as $row) {`
	`108`	`+ foreach (explode("\n", $value) as $row) {`
`109`	`109`	`$output .= sprintf("%s%s%s\n", $prefix, str_repeat(' ', $this->indentation), $row);`
`110`	`110`	`}`
`111`	`111`
`@@ -121,7 +121,7 @@ public function dump($input, $inline = 0, $indent = 0, $flags = 0)`
`121`	`121`	`$blockIndentationIndicator = (' ' === substr($value->getValue(), 0, 1)) ? (string) $this->indentation : '';`
`122`	`122`	`$output .= sprintf(" \|%s\n", $blockIndentationIndicator);`
`123`	`123`
`124`		`- foreach (preg_split('/\n/', $value->getValue()) as $row) {`
	`124`	`+ foreach (explode("\n", $value->getValue()) as $row) {`
`125`	`125`	`$output .= sprintf("%s%s%s\n", $prefix, str_repeat(' ', $this->indentation), $row);`
`126`	`126`	`}`
`127`	`127`