bug #35278 [EventDispatcher] expand listener in place (xabbuh)

nicolas-grekas · nicolas-grekas · commit 2787024e3435 · 2020-01-09T15:01:40.000+01:00
This PR was merged into the 4.3 branch. Discussion ---------- [EventDispatcher] expand listener in place | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #35259 | License | MIT | Doc PR | Commits ------- f5d4073 expand listener in place
diff --git a/src/Symfony/Component/EventDispatcher/EventDispatcher.php b/src/Symfony/Component/EventDispatcher/EventDispatcher.php
@@ -270,7 +270,7 @@ private function sortListeners(string $eventName)
         $this->sorted[$eventName] = [];
 
         foreach ($this->listeners[$eventName] as &$listeners) {
-            foreach ($listeners as $k => $listener) {
+            foreach ($listeners as $k => &$listener) {
                 if (\is_array($listener) && isset($listener[0]) && $listener[0] instanceof \Closure) {
                     $listener[0] = $listener[0]();
                 }

Original file line number	Diff line number	Diff line change
`@@ -270,7 +270,7 @@ private function sortListeners(string $eventName)`
`270`	`270`	`$this->sorted[$eventName] = [];`
`271`	`271`
`272`	`272`	`foreach ($this->listeners[$eventName] as &$listeners) {`
`273`		`- foreach ($listeners as $k => $listener) {`
	`273`	`+ foreach ($listeners as $k => &$listener) {`
`274`	`274`	`if (\is_array($listener) && isset($listener[0]) && $listener[0] instanceof \Closure) {`
`275`	`275`	`$listener[0] = $listener[0]();`
`276`	`276`	`}`