Mention FirewallListenerInterface in the deprecation message

MatTheCat · MatTheCat · commit 311c89fe3ba0 · 2025-06-05T10:40:01.000+02:00
diff --git a/UPGRADE-7.4.md b/UPGRADE-7.4.md
@@ -11,4 +11,4 @@ If you're upgrading from a version below 7.3, follow the [7.3 upgrade guide](UPG
 Security
 --------
 
- * Deprecate callable firewall listeners, extend `AbstractListener` instead
+ * Deprecate callable firewall listeners, extend `AbstractListener` or implement `FirewallListenerInterface` instead
diff --git a/src/Symfony/Bundle/SecurityBundle/CHANGELOG.md b/src/Symfony/Bundle/SecurityBundle/CHANGELOG.md
@@ -4,7 +4,7 @@ CHANGELOG
 7.4
 ---
 
- * Deprecate callable firewall listeners, extend `AbstractListener` instead
+ * Deprecate callable firewall listeners, extend `AbstractListener` or implement `FirewallListenerInterface` instead
 
 7.3
 ---
diff --git a/src/Symfony/Component/Security/Http/Firewall.php b/src/Symfony/Component/Security/Http/Firewall.php
@@ -124,7 +124,7 @@ protected function callListeners(RequestEvent $event, iterable $listeners)
     {
         foreach ($listeners as $listener) {
             if (!$listener instanceof FirewallListenerInterface) {
-                trigger_deprecation('symfony/security-http', '7.4', 'Using a callable as firewall listener is deprecated, extend "%s" instead.', AbstractListener::class);
+                trigger_deprecation('symfony/security-http', '7.4', 'Using a callable as firewall listener is deprecated, extend "%s" or implement "%s" instead.', AbstractListener::class, FirewallListenerInterface::class);
             }
 
             $listener($event);

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ protected function callListeners(RequestEvent $event, iterable $listeners)`
`124`	`124`	`{`
`125`	`125`	`foreach ($listeners as $listener) {`
`126`	`126`	`if (!$listener instanceof FirewallListenerInterface) {`
`127`		`- trigger_deprecation('symfony/security-http', '7.4', 'Using a callable as firewall listener is deprecated, extend "%s" instead.', AbstractListener::class);`
	`127`	`+ trigger_deprecation('symfony/security-http', '7.4', 'Using a callable as firewall listener is deprecated, extend "%s" or implement "%s" instead.', AbstractListener::class, FirewallListenerInterface::class);`
`128`	`128`	`}`
`129`	`129`
`130`	`130`	`$listener($event);`