Review

noniagriconomie · noniagriconomie · commit 3189a589814a · 2019-05-24T11:40:42.000+02:00
diff --git a/src/Symfony/Component/HttpKernel/DataCollector/ConfigDataCollector.php b/src/Symfony/Component/HttpKernel/DataCollector/ConfigDataCollector.php
@@ -172,10 +172,8 @@ public function getSymfonyMinorVersion()
 
     /**
      * Returns if the current Symfony version is a Long-Term Support one.
-     *
-     * @return bool
      */
-    public function isSymfonyLts()
+    public function isSymfonyLts(): bool
     {
         return $this->data['symfony_lts'];
     }
diff --git a/src/Symfony/Component/HttpKernel/Tests/DataCollector/ConfigDataCollectorTest.php b/src/Symfony/Component/HttpKernel/Tests/DataCollector/ConfigDataCollectorTest.php
@@ -36,10 +36,7 @@ public function testCollect()
         $this->assertSame(class_exists('Locale', false) && \Locale::getDefault() ? \Locale::getDefault() : 'n/a', $c->getPhpIntlLocale());
         $this->assertSame(date_default_timezone_get(), $c->getPhpTimezone());
         $this->assertSame(Kernel::VERSION, $c->getSymfonyVersion());
-        $isSymfonyLts = $c->isSymfonyLts();
-        (4 === Kernel::MINOR_VERSION)
-            ? $this->assertTrue($isSymfonyLts)
-            : $this->assertFalse($isSymfonyLts);
+        $this->assertSame(4 === Kernel::MINOR_VERSION, $c->isSymfonyLts());
         $this->assertNull($c->getToken());
         $this->assertSame(\extension_loaded('xdebug'), $c->hasXDebug());
         $this->assertSame(\extension_loaded('Zend OPcache') && filter_var(ini_get('opcache.enable'), FILTER_VALIDATE_BOOLEAN), $c->hasZendOpcache());

Original file line number	Diff line number	Diff line change
`@@ -172,10 +172,8 @@ public function getSymfonyMinorVersion()`
`172`	`172`
`173`	`173`	`/**`
`174`	`174`	`* Returns if the current Symfony version is a Long-Term Support one.`
`175`		`- *`
`176`		`- * @return bool`
`177`	`175`	`*/`
`178`		`- public function isSymfonyLts()`
	`176`	`+ public function isSymfonyLts(): bool`
`179`	`177`	`{`
`180`	`178`	`return $this->data['symfony_lts'];`
`181`	`179`	`}`