minor #32428 [Stopwatch] Fix missing deprecations (yceruto)

fabpot · fabpot · commit 350ec6cc7ed3 · 2019-07-08T15:06:45.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [Stopwatch] Fix missing deprecations | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | no needed Fix #32408 Commits ------- 527bf89 Fix missing deprecations
diff --git a/src/Symfony/Component/HttpKernel/Tests/Debug/TraceableEventDispatcherTest.php b/src/Symfony/Component/HttpKernel/Tests/Debug/TraceableEventDispatcherTest.php
@@ -26,7 +26,7 @@ class TraceableEventDispatcherTest extends TestCase
     public function testStopwatchSections()
     {
         $dispatcher = new TraceableEventDispatcher(new EventDispatcher(), $stopwatch = new Stopwatch());
-        $kernel = $this->getHttpKernel($dispatcher, function () { return new Response(); });
+        $kernel = $this->getHttpKernel($dispatcher, function () { return new Response('', 200, ['X-Debug-Token' => '292e1e']); });
         $request = Request::create('/');
         $response = $kernel->handle($request);
         $kernel->terminate($request, $response);
diff --git a/src/Symfony/Component/Stopwatch/Section.php b/src/Symfony/Component/Stopwatch/Section.php
@@ -82,7 +82,7 @@ public function get($id)
      */
     public function open($id)
     {
-        if (null === $session = $this->get($id)) {
+        if (null === $id || null === $session = $this->get($id)) {
             $session = $this->children[] = new self(microtime(true) * 1000, $this->morePrecision);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ class TraceableEventDispatcherTest extends TestCase`
`26`	`26`	`public function testStopwatchSections()`
`27`	`27`	`{`
`28`	`28`	`$dispatcher = new TraceableEventDispatcher(new EventDispatcher(), $stopwatch = new Stopwatch());`
`29`		`- $kernel = $this->getHttpKernel($dispatcher, function () { return new Response(); });`
	`29`	`+ $kernel = $this->getHttpKernel($dispatcher, function () { return new Response('', 200, ['X-Debug-Token' => '292e1e']); });`
`30`	`30`	`$request = Request::create('/');`
`31`	`31`	`$response = $kernel->handle($request);`
`32`	`32`	`$kernel->terminate($request, $response);`
Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ public function get($id)`
`82`	`82`	`*/`
`83`	`83`	`public function open($id)`
`84`	`84`	`{`
`85`		`- if (null === $session = $this->get($id)) {`
	`85`	`+ if (null === $id \|\| null === $session = $this->get($id)) {`
`86`	`86`	`$session = $this->children[] = new self(microtime(true) * 1000, $this->morePrecision);`
`87`	`87`	`}`
`88`	`88`