Bug #16343 [Router] Too many Routes ?

Jelte Steijaert · Jelte Steijaert · commit 358aa72339bc · 2015-10-30T01:15:25.000+01:00
diff --git a/src/Symfony/Component/Routing/Generator/Dumper/PhpGeneratorDumper.php b/src/Symfony/Component/Routing/Generator/Dumper/PhpGeneratorDumper.php
@@ -16,6 +16,7 @@
  *
  * @author Fabien Potencier <fabien@symfony.com>
  * @author Tobias Schultze <http://tobion.de>
+ * @author Jelte Steijaert <jelte@khepri.be>
  */
 class PhpGeneratorDumper extends GeneratorDumper
 {
@@ -78,7 +79,8 @@ public function __construct(RequestContext \$context, LoggerInterface \$logger =
      */
     private function generateDeclaredRoutes()
     {
-        $routes = "array(\n";
+        $routes = "array(\n        array(\n";
+        $i = 0;
         foreach ($this->getRoutes()->all() as $name => $route) {
             $compiledRoute = $route->compile();
 
@@ -90,7 +92,13 @@ private function generateDeclaredRoutes()
             $properties[] = $compiledRoute->getHostTokens();
             $properties[] = $route->getSchemes();
 
-            $routes .= sprintf("        '%s' => %s,\n", $name, str_replace("\n", '', var_export($properties, true)));
+            $routes .= sprintf("              '%s' => %s,\n", $name, str_replace("\n", '', var_export($properties, true)));
+            if ( $i++%5000 == 0 ) {
+                $routes .= "        ),\n        array(\n";
+            }
+        }
+        if ($i%5000 != 0 || $i == 0) {
+            $routes .= "        ),\n";
         }
         $routes .= '    )';
 
@@ -107,14 +115,23 @@ private function generateGenerateMethod()
         return <<<EOF
     public function generate(\$name, \$parameters = array(), \$referenceType = self::ABSOLUTE_PATH)
     {
-        if (!isset(self::\$declaredRoutes[\$name])) {
+        if (null === (\$route = \$this->getRoute(\$name))) {
             throw new RouteNotFoundException(sprintf('Unable to generate a URL for the named route "%s" as such route does not exist.', \$name));
         }
 
-        list(\$variables, \$defaults, \$requirements, \$tokens, \$hostTokens, \$requiredSchemes) = self::\$declaredRoutes[\$name];
+        list(\$variables, \$defaults, \$requirements, \$tokens, \$hostTokens, \$requiredSchemes) = \$route;
 
         return \$this->doGenerate(\$variables, \$defaults, \$requirements, \$tokens, \$parameters, \$name, \$referenceType, \$hostTokens, \$requiredSchemes);
     }
+
+    private function getRoute(\$name) {
+        foreach( self::\$declaredRoutes as \$routes ) {
+            if (isset(\$routes[\$name])) {
+                return \$routes[\$name];
+            }
+        }
+        return;
+    }
 EOF;
     }
 }
