[Console] Remove redundant method getSaturation()

ivanpepelko · fabpot · commit 38021b5e5543 · 2023-05-15T10:49:32.000+02:00
diff --git a/src/Symfony/Component/Console/Output/AnsiColorMode.php b/src/Symfony/Component/Console/Output/AnsiColorMode.php
@@ -78,25 +78,7 @@ private function convertFromRGB(int $r, int $g, int $b): int
 
     private function degradeHexColorToAnsi4(int $r, int $g, int $b): int
     {
-        if (0 === round($this->getSaturation($r, $g, $b) / 50)) {
-            return 0;
-        }
-
-        return (int) ((round($b / 255) << 2) | (round($g / 255) << 1) | round($r / 255));
-    }
-
-    private function getSaturation(int $r, int $g, int $b): int
-    {
-        $r = $r / 255;
-        $g = $g / 255;
-        $b = $b / 255;
-        $v = max($r, $g, $b);
-
-        if (0 === $diff = $v - min($r, $g, $b)) {
-            return 0;
-        }
-
-        return (int) ((int) $diff * 100 / $v);
+        return round($b / 255) << 2 | (round($g / 255) << 1) | round($r / 255);
     }
 
     /**
diff --git a/src/Symfony/Component/Console/Tests/Output/AnsiColorModeTest.php b/src/Symfony/Component/Console/Tests/Output/AnsiColorModeTest.php
@@ -64,6 +64,16 @@ public static function provideColorsConversion(): \Generator
             AnsiColorMode::Ansi8->name => 248,
             AnsiColorMode::Ansi4->name => 7,
         ]];
+
+        yield ['#000000', [
+            AnsiColorMode::Ansi8->name => 16,
+            AnsiColorMode::Ansi4->name => 0,
+        ]];
+
+        yield ['#ffffff', [
+            AnsiColorMode::Ansi8->name => 231,
+            AnsiColorMode::Ansi4->name => 7,
+        ]];
     }
 
     public function testColorsConversionWithoutSharp()
