feature #32423 [ServerBundle] Display all logs by default (lyrixx)

fabpot · fabpot · commit 3e2ee71bcb8d · 2019-07-08T11:44:22.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [ServerBundle] Display all logs by default | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32111 | License | MIT | Doc PR | Instead of relying on `-vvv` behavior, we display all logs. End user has two ways of filtering now: * with the `--filter` options * by configuring the handler in `config/dev/monolog.yaml` Commits ------- 54b0809 [ServerBundle] Display all logs by default
diff --git a/src/Symfony/Bundle/WebServerBundle/Command/ServerLogCommand.php b/src/Symfony/Bundle/WebServerBundle/Command/ServerLogCommand.php
@@ -12,6 +12,7 @@
 namespace Symfony\Bundle\WebServerBundle\Command;
 
 use Monolog\Formatter\FormatterInterface;
+use Monolog\Logger;
 use Symfony\Bridge\Monolog\Formatter\ConsoleFormatter;
 use Symfony\Bridge\Monolog\Handler\ConsoleHandler;
 use Symfony\Component\Console\Command\Command;
@@ -85,7 +86,9 @@ protected function execute(InputInterface $input, OutputInterface $output)
             $this->el = new ExpressionLanguage();
         }
 
-        $this->handler = new ConsoleHandler($output);
+        $this->handler = new ConsoleHandler($output, true, [
+            OutputInterface::VERBOSITY_NORMAL => Logger::DEBUG,
+        ]);
 
         $this->handler->setFormatter(new ConsoleFormatter([
             'format' => str_replace('\n', "\n", $input->getOption('format')),
@@ -143,13 +146,11 @@ private function getLogs($socket)
 
     private function displayLog(InputInterface $input, OutputInterface $output, $clientId, array $record)
     {
-        if ($this->handler->isHandling($record)) {
-            if (isset($record['log_id'])) {
-                $clientId = unpack('H*', $record['log_id'])[1];
-            }
-            $logBlock = sprintf('<bg=%s> </>', self::$bgColor[$clientId % 8]);
-            $output->write($logBlock);
+        if (isset($record['log_id'])) {
+            $clientId = unpack('H*', $record['log_id'])[1];
         }
+        $logBlock = sprintf('<bg=%s> </>', self::$bgColor[$clientId % 8]);
+        $output->write($logBlock);
 
         $this->handler->handle($record);
     }
