minor #37669 [EventDispatcher] Minor: Avoid not needed null check in dispatch() (brainexe)

fabpot · fabpot · commit 4105e935ac1b · 2020-08-02T10:13:42.000+02:00
This PR was merged into the 5.2-dev branch. Discussion ---------- [EventDispatcher] Minor: Avoid not needed null check in dispatch() | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | License | MIT | Doc PR | - Just found a not needed null check in the heavyly called EventDispatcher::dispatch() method - the $eventName get's always a string now - no null anymore, as it gets the class name instead. Commits ------- 0d36c11 [EventDispatcher] Avoid not needed null check in dispatch()
diff --git a/src/Symfony/Component/EventDispatcher/EventDispatcher.php b/src/Symfony/Component/EventDispatcher/EventDispatcher.php
@@ -49,7 +49,7 @@ public function dispatch(object $event, string $eventName = null): object
     {
         $eventName = $eventName ?? \get_class($event);
 
-        if (null !== $this->optimized && null !== $eventName) {
+        if (null !== $this->optimized) {
             $listeners = $this->optimized[$eventName] ?? (empty($this->listeners[$eventName]) ? [] : $this->optimizeListeners($eventName));
         } else {
             $listeners = $this->getListeners($eventName);

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ public function dispatch(object $event, string $eventName = null): object`
`49`	`49`	`{`
`50`	`50`	`$eventName = $eventName ?? \get_class($event);`
`51`	`51`
`52`		`- if (null !== $this->optimized && null !== $eventName) {`
	`52`	`+ if (null !== $this->optimized) {`
`53`	`53`	`$listeners = $this->optimized[$eventName] ?? (empty($this->listeners[$eventName]) ? [] : $this->optimizeListeners($eventName));`
`54`	`54`	`} else {`
`55`	`55`	`$listeners = $this->getListeners($eventName);`