minor #61177 [FrameworkBundle] Remove deprecated TranslationUpdateCommand (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 419f671ca59f · 2025-07-21T14:29:13.000+02:00
This PR was merged into the 8.0 branch. Discussion ---------- [FrameworkBundle] Remove deprecated `TranslationUpdateCommand` | Q | A | ------------- | --- | Branch? | 8.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Commits ------- bd2c3e4 [FrameworkBundle] Remove TranslationUpdateCommand
diff --git a/UPGRADE-8.0.md b/UPGRADE-8.0.md
@@ -213,6 +213,7 @@ FrameworkBundle
  * Remove `session.sid_length` and `session.sid_bits_per_character` config options
  * Remove the `router.cache_dir` config option
  * Remove the `validation.cache` option
+ * Remove `TranslationUpdateCommand` in favor of `TranslationExtractCommand`
 
 HttpFoundation
 --------------
diff --git a/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md b/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md
@@ -17,6 +17,7 @@ CHANGELOG
  * Remove `session.sid_length` and `session.sid_bits_per_character` config options
  * Remove the `router.cache_dir` config option
  * Remove the `validation.cache` option
+ * Remove `TranslationUpdateCommand` in favor of `TranslationExtractCommand`
 
 7.4
 ---
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
@@ -354,7 +354,7 @@ private function addProfilerSection(ArrayNodeDefinition $rootNode): void
                         ->booleanNode('only_exceptions')->defaultFalse()->end()
                         ->booleanNode('only_main_requests')->defaultFalse()->end()
                         ->scalarNode('dsn')->defaultValue('file:%kernel.cache_dir%/profiler')->end()
-                        ->booleanNode('collect_serializer_data')->info('Enables the serializer data collector and profiler panel.')->defaultFalse()->end()
+                        ->enumNode('collect_serializer_data')->values([true])->defaultTrue()->end() // to be @deprecated in Symfony 8.1
                     ->end()
                 ->end()
             ->end()
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
@@ -972,11 +972,7 @@ private function registerProfilerConfiguration(array $config, ContainerBuilder $
             $loader->load('notifier_debug.php');
         }
 
-        if (false === $config['collect_serializer_data']) {
-            trigger_deprecation('symfony/framework-bundle', '7.3', 'Setting the "framework.profiler.collect_serializer_data" config option to "false" is deprecated.');
-        }
-
-        if ($this->isInitializedConfigEnabled('serializer') && $config['collect_serializer_data']) {
+        if ($this->isInitializedConfigEnabled('serializer')) {
             $loader->load('serializer_debug.php');
         }
 
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/ConfigurationTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/ConfigurationTest.php
@@ -25,7 +25,6 @@
 use Symfony\Component\JsonStreamer\JsonStreamWriter;
 use Symfony\Component\Lock\Store\SemaphoreStore;
 use Symfony\Component\Mailer\Mailer;
-use Symfony\Component\Messenger\MessageBusInterface;
 use Symfony\Component\Notifier\Notifier;
 use Symfony\Component\RateLimiter\Policy\TokenBucketLimiter;
 use Symfony\Component\RemoteEvent\RemoteEvent;
@@ -688,7 +687,7 @@ protected static function getBundleDefaultConfig()
                 'dsn' => 'file:%kernel.cache_dir%/profiler',
                 'collect' => true,
                 'collect_parameter' => null,
-                'collect_serializer_data' => false,
+                'collect_serializer_data' => true,
             ],
             'translator' => [
                 'enabled' => !class_exists(FullStack::class),

Original file line number	Diff line number	Diff line change
`@@ -972,11 +972,7 @@ private function registerProfilerConfiguration(array $config, ContainerBuilder $`
`972`	`972`	`$loader->load('notifier_debug.php');`
`973`	`973`	`}`
`974`	`974`
`975`		`- if (false === $config['collect_serializer_data']) {`
`976`		`- trigger_deprecation('symfony/framework-bundle', '7.3', 'Setting the "framework.profiler.collect_serializer_data" config option to "false" is deprecated.');`
`977`		`- }`
`978`		`-`
`979`		`- if ($this->isInitializedConfigEnabled('serializer') && $config['collect_serializer_data']) {`
	`975`	`+ if ($this->isInitializedConfigEnabled('serializer')) {`
`980`	`976`	`$loader->load('serializer_debug.php');`
`981`	`977`	`}`
`982`	`978`