[Notifier] Introduce LengthException

OskarStark · OskarStark · commit 437cad7c2b42 · 2020-12-16T12:16:51.000+01:00
diff --git a/src/Symfony/Component/Notifier/Bridge/Discord/DiscordTransport.php b/src/Symfony/Component/Notifier/Bridge/Discord/DiscordTransport.php
@@ -11,7 +11,7 @@
 
 namespace Symfony\Component\Notifier\Bridge\Discord;
 
-use Symfony\Component\Notifier\Exception\LogicException;
+use Symfony\Component\Notifier\Exception\LengthException;
 use Symfony\Component\Notifier\Exception\TransportException;
 use Symfony\Component\Notifier\Exception\UnsupportedMessageTypeException;
 use Symfony\Component\Notifier\Message\ChatMessage;
@@ -67,7 +67,7 @@ protected function doSend(MessageInterface $message): SentMessage
         $content = $message->getSubject();
 
         if (\strlen($content) > 2000) {
-            throw new LogicException('The subject length of a Discord message must not exceed 2000 characters.');
+            throw new LengthException('The subject length of a Discord message must not exceed 2000 characters.');
         }
 
         $endpoint = sprintf('https://%s/api/webhooks/%s/%s', $this->getEndpoint(), $this->webhookId, $this->token);
diff --git a/src/Symfony/Component/Notifier/Bridge/Discord/Tests/DiscordTransportTest.php b/src/Symfony/Component/Notifier/Bridge/Discord/Tests/DiscordTransportTest.php
@@ -14,7 +14,7 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\HttpClient\MockHttpClient;
 use Symfony\Component\Notifier\Bridge\Discord\DiscordTransport;
-use Symfony\Component\Notifier\Exception\LogicException;
+use Symfony\Component\Notifier\Exception\LengthException;
 use Symfony\Component\Notifier\Exception\TransportException;
 use Symfony\Component\Notifier\Exception\UnsupportedMessageTypeException;
 use Symfony\Component\Notifier\Message\ChatMessage;
@@ -55,7 +55,7 @@ public function testSendChatMessageWithMoreThan2000CharsThrowsLogicException()
     {
         $transport = new DiscordTransport('testToken', 'testChannel', $this->createMock(HttpClientInterface::class));
 
-        $this->expectException(LogicException::class);
+        $this->expectException(LengthException::class);
         $this->expectExceptionMessage('The subject length of a Discord message must not exceed 2000 characters.');
 
         $transport->send(new ChatMessage(str_repeat('d', 2001)));
diff --git a/src/Symfony/Component/Notifier/Bridge/Slack/Block/SlackHeaderBlock.php b/src/Symfony/Component/Notifier/Bridge/Slack/Block/SlackHeaderBlock.php
@@ -11,7 +11,7 @@
 
 namespace Symfony\Component\Notifier\Bridge\Slack\Block;
 
-use Symfony\Component\Notifier\Exception\LogicException;
+use Symfony\Component\Notifier\Exception\LengthException;
 
 /**
  * @author Tomas Norkūnas <norkunas.tom@gmail.com>
@@ -26,7 +26,7 @@ final class SlackHeaderBlock extends AbstractSlackBlock
     public function __construct(string $text)
     {
         if (\strlen($text) > self::TEXT_LIMIT) {
-            throw new LogicException(sprintf('Maximum length for the text is %d characters.', self::TEXT_LIMIT));
+            throw new LengthException(sprintf('Maximum length for the text is %d characters.', self::TEXT_LIMIT));
         }
 
         $this->options = [
@@ -41,7 +41,7 @@ public function __construct(string $text)
     public function id(string $id): self
     {
         if (\strlen($id) > self::ID_LIMIT) {
-            throw new LogicException(sprintf('Maximum length for the block id is %d characters.', self::ID_LIMIT));
+            throw new LengthException(sprintf('Maximum length for the block id is %d characters.', self::ID_LIMIT));
         }
 
         $this->options['block_id'] = $id;
diff --git a/src/Symfony/Component/Notifier/Bridge/Slack/Tests/Block/SlackHeaderBlockTest.php b/src/Symfony/Component/Notifier/Bridge/Slack/Tests/Block/SlackHeaderBlockTest.php
@@ -13,7 +13,7 @@
 
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Notifier\Bridge\Slack\Block\SlackHeaderBlock;
-use Symfony\Component\Notifier\Exception\LogicException;
+use Symfony\Component\Notifier\Exception\LengthException;
 
 final class SlackHeaderBlockTest extends TestCase
 {
@@ -34,15 +34,15 @@ public function testCanBeInstantiated(): void
 
     public function testThrowsWhenTextExceedsCharacterLimit(): void
     {
-        $this->expectException(LogicException::class);
+        $this->expectException(LengthException::class);
         $this->expectExceptionMessage('Maximum length for the text is 150 characters.');
 
         new SlackHeaderBlock(str_repeat('h', 151));
     }
 
     public function testThrowsWhenBlockIdExceedsCharacterLimit(): void
     {
-        $this->expectException(LogicException::class);
+        $this->expectException(LengthException::class);
         $this->expectExceptionMessage('Maximum length for the block id is 255 characters.');
 
         $header = new SlackHeaderBlock('header');
diff --git a/src/Symfony/Component/Notifier/Exception/LengthException.php b/src/Symfony/Component/Notifier/Exception/LengthException.php
@@ -0,0 +1,21 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\Notifier\Exception;
+
+/**
+ * @author Oskar Stark <oskarstark@googlemail.com>
+ *
+ * @experimental in 5.3
+ */
+class LengthException extends LogicException
+{
+}

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`
`12`	`12`	`namespace Symfony\Component\Notifier\Bridge\Slack\Block;`
`13`	`13`
`14`		`-use Symfony\Component\Notifier\Exception\LogicException;`
	`14`	`+use Symfony\Component\Notifier\Exception\LengthException;`
`15`	`15`
`16`	`16`	`/**`
`17`	`17`	`* @author Tomas Norkūnas <norkunas.tom@gmail.com>`
`@@ -26,7 +26,7 @@ final class SlackHeaderBlock extends AbstractSlackBlock`
`26`	`26`	`public function __construct(string $text)`
`27`	`27`	`{`
`28`	`28`	`if (\strlen($text) > self::TEXT_LIMIT) {`
`29`		`- throw new LogicException(sprintf('Maximum length for the text is %d characters.', self::TEXT_LIMIT));`
	`29`	`+ throw new LengthException(sprintf('Maximum length for the text is %d characters.', self::TEXT_LIMIT));`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`$this->options = [`
`@@ -41,7 +41,7 @@ public function __construct(string $text)`
`41`	`41`	`public function id(string $id): self`
`42`	`42`	`{`
`43`	`43`	`if (\strlen($id) > self::ID_LIMIT) {`
`44`		`- throw new LogicException(sprintf('Maximum length for the block id is %d characters.', self::ID_LIMIT));`
	`44`	`+ throw new LengthException(sprintf('Maximum length for the block id is %d characters.', self::ID_LIMIT));`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`$this->options['block_id'] = $id;`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@`
`13`	`13`
`14`	`14`	`use PHPUnit\Framework\TestCase;`
`15`	`15`	`use Symfony\Component\Notifier\Bridge\Slack\Block\SlackHeaderBlock;`
`16`		`-use Symfony\Component\Notifier\Exception\LogicException;`
	`16`	`+use Symfony\Component\Notifier\Exception\LengthException;`
`17`	`17`
`18`	`18`	`final class SlackHeaderBlockTest extends TestCase`
`19`	`19`	`{`
`@@ -34,15 +34,15 @@ public function testCanBeInstantiated(): void`
`34`	`34`
`35`	`35`	`public function testThrowsWhenTextExceedsCharacterLimit(): void`
`36`	`36`	`{`
`37`		`- $this->expectException(LogicException::class);`
	`37`	`+ $this->expectException(LengthException::class);`
`38`	`38`	`$this->expectExceptionMessage('Maximum length for the text is 150 characters.');`
`39`	`39`
`40`	`40`	`new SlackHeaderBlock(str_repeat('h', 151));`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`public function testThrowsWhenBlockIdExceedsCharacterLimit(): void`
`44`	`44`	`{`
`45`		`- $this->expectException(LogicException::class);`
	`45`	`+ $this->expectException(LengthException::class);`
`46`	`46`	`$this->expectExceptionMessage('Maximum length for the block id is 255 characters.');`
`47`	`47`
`48`	`48`	`$header = new SlackHeaderBlock('header');`