Add support for tags facet on Bluesky notifier

romainneutron · romainneutron · commit 4697321c616c · 2025-02-15T20:54:50.000+01:00
diff --git a/src/Symfony/Component/Notifier/Bridge/Bluesky/BlueskyTransport.php b/src/Symfony/Component/Notifier/Bridge/Bluesky/BlueskyTransport.php
@@ -208,6 +208,24 @@ private function parseFacets(string $input): array
             ];
         }
 
+        // partial/naive URL regex based on: https://github.com/bluesky-social/atproto/blob/main/packages/api/src/rich-text/util.ts
+        // https://github.com/bluesky-social/atproto/blob/main/packages/api/src/rich-text/detection.ts
+        $regex = '/(?:^|\s)(#[\p{L}\p{N}]+)/u';
+        foreach ($this->getMatchAndPosition($text, $regex) as $match) {
+            $facets[] = [
+                'index' => [
+                    'byteStart' => $match['start'],
+                    'byteEnd' => $match['end'],
+                ],
+                'features' => [
+                    [
+                        '$type' => 'app.bsky.richtext.facet#tag',
+                        'tag' => $match['match'],
+                    ],
+                ],
+            ];
+        }
+
         return $facets;
     }
 
diff --git a/src/Symfony/Component/Notifier/Bridge/Bluesky/Tests/BlueskyTransportTest.php b/src/Symfony/Component/Notifier/Bridge/Bluesky/Tests/BlueskyTransportTest.php
@@ -238,6 +238,39 @@ public function testParseFacetsUrlWithEmoji()
         $this->assertEquals($expected, $output);
     }
 
+    public function testParseFacetsHashTags()
+    {
+        $input = 'Salut #test #123 #テスト http://bsky.app';
+        $expected = [
+            [
+                'index' => ['byteStart' => 28, 'byteEnd' => 43],
+                'features' => [
+                    ['$type' => 'app.bsky.richtext.facet#link', 'uri' => 'http://bsky.app'],
+                ],
+            ],
+            [
+                'index' => ['byteStart' => 6, 'byteEnd' => 11],
+                'features' => [
+                    ['$type' => 'app.bsky.richtext.facet#tag', 'tag' => '#test'],
+                ],
+            ],
+            [
+                'index' => ['byteStart' => 12, 'byteEnd' => 16],
+                'features' => [
+                    ['$type' => 'app.bsky.richtext.facet#tag', 'tag' => '#123'],
+                ],
+            ],
+            [
+                'index' => ['byteStart' => 17, 'byteEnd' => 27],
+                'features' => [
+                    ['$type' => 'app.bsky.richtext.facet#tag', 'tag' => '#テスト'],
+                ],
+            ],
+        ];
+        $output = $this->parseFacets($input);
+        $this->assertEquals($expected, $output);
+    }
+
     /**
      * Example from https://github.com/bluesky-social/atproto-website/blob/main/examples/create_bsky_post.py.
      */
