[FrameworkBundle] set default session.handler alias if handler_id is not provided

Youssef BENHSSAIEN · fabpot · commit 46c8c3791b45 · 2020-07-23T08:39:55.000+02:00
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
@@ -880,6 +880,7 @@ private function registerSessionConfiguration(array $config, ContainerBuilder $c
             // Set the handler class to be null
             $container->getDefinition('session.storage.native')->replaceArgument(1, null);
             $container->getDefinition('session.storage.php_bridge')->replaceArgument(0, null);
+            $container->setAlias('session.handler', 'session.handler.native_file')->setPrivate(true);
         } else {
             $container->setAlias('session.handler', $config['handler_id'])->setPrivate(true);
         }
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php
@@ -463,6 +463,7 @@ public function testNullSessionHandler()
         $this->assertTrue($container->hasDefinition('session'), '->registerSessionConfiguration() loads session.xml');
         $this->assertNull($container->getDefinition('session.storage.native')->getArgument(1));
         $this->assertNull($container->getDefinition('session.storage.php_bridge')->getArgument(0));
+        $this->assertEquals('session.handler.native_file', (string) $container->getAlias('session.handler'));
     }
 
     public function testRequest()

Original file line number	Diff line number	Diff line change
`@@ -880,6 +880,7 @@ private function registerSessionConfiguration(array $config, ContainerBuilder $c`
`880`	`880`	`// Set the handler class to be null`
`881`	`881`	`$container->getDefinition('session.storage.native')->replaceArgument(1, null);`
`882`	`882`	`$container->getDefinition('session.storage.php_bridge')->replaceArgument(0, null);`
	`883`	`+ $container->setAlias('session.handler', 'session.handler.native_file')->setPrivate(true);`
`883`	`884`	`} else {`
`884`	`885`	`$container->setAlias('session.handler', $config['handler_id'])->setPrivate(true);`
`885`	`886`	`}`
Original file line number	Diff line number	Diff line change
`@@ -463,6 +463,7 @@ public function testNullSessionHandler()`
`463`	`463`	`$this->assertTrue($container->hasDefinition('session'), '->registerSessionConfiguration() loads session.xml');`
`464`	`464`	`$this->assertNull($container->getDefinition('session.storage.native')->getArgument(1));`
`465`	`465`	`$this->assertNull($container->getDefinition('session.storage.php_bridge')->getArgument(0));`
	`466`	`+ $this->assertEquals('session.handler.native_file', (string) $container->getAlias('session.handler'));`
`466`	`467`	`}`
`467`	`468`
`468`	`469`	`public function testRequest()`