Skip to content

Commit 4857210

Browse files
fabpotfabpot
committed
minor #51621 [WebProfilerBundle] Replace last "old" icon + delete ICONS_LICENCE.txt (smnandre)
This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [WebProfilerBundle] Replace last "old" icon + delete ICONS_LICENCE.txt | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | License | MIT Two (related) things in this PR * replace two icons used in the Messenger profiler panel with a Tabler-Icon one (following the conventions used since the [profiler redesign](#47148) ) * delete the now outdated `ICONS_LICENCE.txt` file (as there is no concerned icons remaining, and there is now a [LICENCE.txt](https://github.com/symfony/symfony/blob/6.4/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Icon/LICENSE.txt) file in the `Resources/views/Icon/` directory) I targeted the 6.4 branch as there is no BC in code.. but i don't know how to handle a licence change 🤷🏻‍♂️ --- | Previous icons | After this PR | | - | - | | ![previous-icons](https://github.com/symfony/symfony/assets/1359581/4bd2ab76-94ba-435d-9176-84547f406442) | ![tabler-icon](https://github.com/symfony/symfony/assets/1359581/f8042a82-d963-4bf7-94a2-958d9df53c9e) | Commits ------- 584c512 [WebProfilerBundle] Replace last "old" icon + delete ICONS_LICENCE.txt
2 parents 8d2b79e + 584c512 commit 4857210

File tree

5 files changed

+10
-12
lines changed

5 files changed

+10
-12
lines changed

‎src/Symfony/Bundle/WebProfilerBundle/Resources/ICONS_LICENSE.txt

Lines changed: 0 additions & 5 deletions
This file was deleted.

‎src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/messenger.html.twig

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,9 @@
88
.message-item tbody tr td:first-child { width: 170px; }
99
1010
.message-item .label { float: right; padding: 1px 5px; opacity: .75; margin-left: 5px; }
11-
.message-item .toggle-button { position: absolute; right: 6px; top: 6px; opacity: .5; pointer-events: none }
11+
.message-item .toggle-button { position: absolute; right: 6px; top: 6px; opacity: .5; pointer-events: none; color: inherit; }
1212
.message-item .icon svg { height: 24px; width: 24px; }
13+
.message-item .icon-close svg { transform: rotate(180deg); }
1314
1415
.message-item .sf-toggle-off .icon-close, .sf-toggle-on .icon-open { display: none; }
1516
.message-item .sf-toggle-off .icon-open, .sf-toggle-on .icon-close { display: block; }
@@ -131,10 +132,10 @@
131132
{% if dispatchCall.exception is defined %}
132133
<span class="label status-error">exception</span>
133134
{% endif %}
134-
<a class="toggle-button">
135-
<span class="icon icon-close">{{ source('@WebProfiler/images/icon-minus-square.svg') }}</span>
136-
<span class="icon icon-open">{{ source('@WebProfiler/images/icon-plus-square.svg') }}</span>
137-
</a>
135+
<button class="btn btn-link toggle-button" type="button">
136+
<span class="icon icon-close">{{ source('@WebProfiler/Icon/chevron-down.svg') }}</span>
137+
<span class="icon icon-open">{{ source('@WebProfiler/Icon/chevron-down.svg') }}</span>
138+
</button>
138139
</th>
139140
</tr>
140141
</thead>

‎src/Symfony/Bundle/WebProfilerBundle/Resources/views/Icon/chevron-down.svg

Lines changed: 4 additions & 0 deletions
Loading

‎src/Symfony/Bundle/WebProfilerBundle/Resources/views/images/icon-minus-square.svg

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎src/Symfony/Bundle/WebProfilerBundle/Resources/views/images/icon-plus-square.svg

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy