[Serializer] Fix ObjectNormalizer that doesn't use default_context config option

wuchen90 · wuchen90 · commit 4a39eb4c5416 · 2022-09-21T09:16:32.000+02:00
diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/config/serializer.php b/src/Symfony/Bundle/FrameworkBundle/Resources/config/serializer.php
@@ -124,7 +124,6 @@
                 service('property_info')->ignoreOnInvalid(),
                 service('serializer.mapping.class_discriminator_resolver')->ignoreOnInvalid(),
                 null,
-                [],
             ])
             ->tag('serializer.normalizer', ['priority' => -1000])
 
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/SerializerTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/SerializerTest.php
@@ -32,6 +32,22 @@ public function testDeserializeArrayOfObject()
 
         $this->assertEquals($expected, $result);
     }
+
+    public function testObjectNormalizerUsesDefaultContextConfigOption()
+    {
+        static::bootKernel(['test_case' => 'Serializer']);
+
+        $serializer = static::getContainer()->get('serializer.normalizer.object.alias');
+
+        $reflectionObject = new \ReflectionObject($serializer);
+        $property = $reflectionObject->getProperty('defaultContext');
+        $property->setAccessible(true);
+
+        $defaultContext = $property->getValue($serializer);
+
+        self::assertArrayHasKey('fake_context_option', $defaultContext);
+        self::assertEquals('foo', $defaultContext['fake_context_option']);
+    }
 }
 
 class Foo
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/app/Serializer/config.yml b/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/app/Serializer/config.yml
@@ -6,9 +6,16 @@ framework:
         enabled: true
         default_context:
             enable_max_depth: true
+            # The option below is used in \Symfony\Bundle\FrameworkBundle\Tests\Functional\SerializerTest::testObjectNormalizerUsesDefaultContextConfigOption
+            # to assert that the `default_context` is taken into account in serializers
+            fake_context_option: foo
     property_info: { enabled: true }
 
 services:
     serializer.alias:
         alias: serializer
         public: true
+
+    serializer.normalizer.object.alias:
+        alias: serializer.normalizer.object
+        public: true
