feature #15697 [BrowserKit] Added isFollowingRedirects and getMaxRedirects methods (Naktibalda)

fabpot · fabpot · commit 4a98f287bd6a · 2015-09-26T10:21:45.000+02:00
This PR was submitted for the 2.3 branch but it was merged into the 2.8 branch instead (closes #15697). Discussion ---------- [BrowserKit] Added isFollowingRedirects and getMaxRedirects methods | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- b475607 [BrowserKit] Added isFollowingRedirects and getMaxRedirects methods
diff --git a/src/Symfony/Component/BrowserKit/Client.php b/src/Symfony/Component/BrowserKit/Client.php
@@ -74,6 +74,16 @@ public function followRedirects($followRedirect = true)
         $this->followRedirects = (bool) $followRedirect;
     }
 
+    /**
+     * Returns whether client automatically follows redirects or not.
+     *
+     * @return bool
+     */
+    public function isFollowingRedirects()
+    {
+        return $this->followRedirects;
+    }
+
     /**
      * Sets the maximum number of requests that crawler can follow.
      *
@@ -85,6 +95,16 @@ public function setMaxRedirects($maxRedirects)
         $this->followRedirects = -1 != $this->maxRedirects;
     }
 
+    /**
+     * Returns the maximum number of requests that crawler can follow.
+     *
+     * @return int
+     */
+    public function getMaxRedirects()
+    {
+        return $this->maxRedirects;
+    }
+
     /**
      * Sets the insulated flag.
      *
diff --git a/src/Symfony/Component/BrowserKit/Tests/ClientTest.php b/src/Symfony/Component/BrowserKit/Tests/ClientTest.php
@@ -492,6 +492,22 @@ public function testFollowRedirectWithPort()
         $this->assertEquals($headers, $client->getRequest()->getServer());
     }
 
+    public function testIsFollowingRedirects()
+    {
+        $client = new TestClient();
+        $this->assertTrue($client->isFollowingRedirects(), '->getFollowRedirects() returns default value');
+        $client->followRedirects(false);
+        $this->assertFalse($client->isFollowingRedirects(), '->getFollowRedirects() returns assigned value');
+    }
+
+    public function testGetMaxRedirects()
+    {
+        $client = new TestClient();
+        $this->assertEquals(-1, $client->getMaxRedirects(), '->getMaxRedirects() returns default value');
+        $client->setMaxRedirects(3);
+        $this->assertEquals(3, $client->getMaxRedirects(), '->getMaxRedirects() returns assigned value');
+    }
+
     public function testBack()
     {
         $client = new TestClient();
