[OptionsResolver] Fix force prepend normalizer

hason · hason · commit 4bc7f93f1e22 · 2020-07-10T11:08:50.000+02:00
diff --git a/src/Symfony/Component/OptionsResolver/OptionsResolver.php b/src/Symfony/Component/OptionsResolver/OptionsResolver.php
@@ -531,6 +531,7 @@ public function addNormalizer(string $option, \Closure $normalizer, bool $forceP
             throw new UndefinedOptionsException(sprintf('The option "%s" does not exist. Defined options are: "%s".', $this->formatOptions([$option]), implode('", "', array_keys($this->defined))));
         }
 
+        $this->normalizers[$option] = $this->normalizers[$option] ?? [];
         if ($forcePrepend) {
             array_unshift($this->normalizers[$option], $normalizer);
         } else {
diff --git a/src/Symfony/Component/OptionsResolver/Tests/OptionsResolverTest.php b/src/Symfony/Component/OptionsResolver/Tests/OptionsResolverTest.php
@@ -1506,6 +1506,17 @@ public function testForcePrependNormalizerClosure()
         $this->assertEquals(['foo' => '2nd-normalized-1st-normalized-bar'], $this->resolver->resolve());
     }
 
+    public function testForcePrependNormalizerForResolverWithoutPreviousNormalizers()
+    {
+        // defined by superclass
+        $this->resolver->setDefault('foo', 'bar');
+        $this->resolver->addNormalizer('foo', function (Options $options, $value) {
+            return '1st-normalized-'.$value;
+        }, true);
+
+        $this->assertEquals(['foo' => '1st-normalized-bar'], $this->resolver->resolve());
+    }
+
     public function testAddNormalizerFailsIfUnknownOption()
     {
         $this->expectException('Symfony\Component\OptionsResolver\Exception\UndefinedOptionsException');

Original file line number	Diff line number	Diff line change
`@@ -531,6 +531,7 @@ public function addNormalizer(string $option, \Closure $normalizer, bool $forceP`
`531`	`531`	`throw new UndefinedOptionsException(sprintf('The option "%s" does not exist. Defined options are: "%s".', $this->formatOptions([$option]), implode('", "', array_keys($this->defined))));`
`532`	`532`	`}`
`533`	`533`
	`534`	`+ $this->normalizers[$option] = $this->normalizers[$option] ?? [];`
`534`	`535`	`if ($forcePrepend) {`
`535`	`536`	`array_unshift($this->normalizers[$option], $normalizer);`
`536`	`537`	`} else {`