[WIP] Code clarifications

filiplikavcan · filiplikavcan · commit 4dcd5a4c2bad · 2022-10-04T19:47:57.000+02:00
diff --git a/src/Symfony/Component/Form/Extension/HttpFoundation/HttpFoundationRequestHandler.php b/src/Symfony/Component/Form/Extension/HttpFoundation/HttpFoundationRequestHandler.php
@@ -58,8 +58,11 @@ public function handleRequest(FormInterface $form, mixed $request = null)
                 $data = $request->query->all();
             } else {
                 $missingData = $this->missingDataHandler->missingData;
+                $queryData = $request->query->all()[$name] ?? $missingData;
 
-                if ($missingData === $data = $this->missingDataHandler->handle($form, $request->query->all()[$name] ?? $missingData)) {
+                $data = $this->missingDataHandler->handle($form, $queryData);
+
+                if ($missingData === $data) {
                     // Don't submit GET requests if the form's name does not exist
                     // in the request
                     return;
diff --git a/src/Symfony/Component/Form/Tests/AbstractRequestHandlerTest.php b/src/Symfony/Component/Form/Tests/AbstractRequestHandlerTest.php
@@ -78,8 +78,7 @@ public function testSubmitCheckboxInCollectionFormWithEmptyData($method)
             'method' => $method,
         ]);
 
-        $this->setRequestData($method, [
-        ]);
+        $this->setRequestData($method, []);
 
         $this->requestHandler->handleRequest($form, $this->request);
 
