Prevent empty request body stream in HttplugClient and Psr18Client

ajgarlag · nicolas-grekas · commit 508d6059368b · 2025-02-04T11:47:33.000+01:00
This prevents adding `Content-Length` and `Transfer-Encoding` headers
when sending a request with an empty body using CurlHttpClient
diff --git a/src/Symfony/Component/HttpClient/HttplugClient.php b/src/Symfony/Component/HttpClient/HttplugClient.php
@@ -231,7 +231,9 @@ private function sendPsr7Request(RequestInterface $request, ?bool $buffer = null
                 $headers['Content-Length'] = [$size];
             }
 
-            if (0 <= $size && $size < 1 << 21) {
+            if (0 === $size) {
+                $body = '';
+            } elseif (0 < $size && $size < 1 << 21) {
                 if ($body->isSeekable()) {
                     try {
                         $body->seek(0);
diff --git a/src/Symfony/Component/HttpClient/Psr18Client.php b/src/Symfony/Component/HttpClient/Psr18Client.php
@@ -91,11 +91,13 @@ public function sendRequest(RequestInterface $request): ResponseInterface
             $headers = $request->getHeaders();
 
             $size = $request->getHeader('content-length')[0] ?? -1;
-            if (0 > $size && 0 <= $size = $body->getSize() ?? -1) {
+            if (0 > $size && 0 < $size = $body->getSize() ?? -1) {
                 $headers['Content-Length'] = [$size];
             }
 
-            if (0 <= $size && $size < 1 << 21) {
+            if (0 === $size) {
+                $body = '';
+            } elseif (0 < $size && $size < 1 << 21) {
                 if ($body->isSeekable()) {
                     try {
                         $body->seek(0);
