bug #44479 [HttpClient] Double check if handle is complete (Nyholm)

nicolas-grekas · nicolas-grekas · commit 513fc4cbc05a · 2021-12-11T16:18:44.000+01:00
This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [HttpClient] Double check if handle is complete | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | This is a forward compatibility fix. We did the same in Guzzle after a comment from bagder. guzzle/guzzle#2892 (comment) Basically, if libcurl decides to add an other value for `msg`, then our code will break without this PR. The only value for `msg` with current latest version of curl is `CURLMSG_DONE` which means that this is not a bugfix yet.. but it make sure that we respect the libcurl API. Commits ------- f35a6ad [HttpClient] Double check if handle is complete
diff --git a/src/Symfony/Component/HttpClient/Response/CurlResponse.php b/src/Symfony/Component/HttpClient/Response/CurlResponse.php
@@ -277,6 +277,9 @@ private static function perform(ClientState $multi, array &$responses = null): v
             while (\CURLM_CALL_MULTI_PERFORM === curl_multi_exec($multi->handle, $active));
 
             while ($info = curl_multi_info_read($multi->handle)) {
+                if (\CURLMSG_DONE !== $info['msg']) {
+                    continue;
+                }
                 $result = $info['result'];
                 $id = (int) $ch = $info['handle'];
                 $waitFor = @curl_getinfo($ch, \CURLINFO_PRIVATE) ?: '_0';
