[Translator] Performance improvement in MessageCatalogue and catalogue operations.

ArtemBrovko · ArtemBrovko · commit 5179af4796f0 · 2019-12-28T16:59:49.000+02:00
diff --git a/src/Symfony/Component/Translation/MessageCatalogue.php b/src/Symfony/Component/Translation/MessageCatalogue.php
@@ -130,7 +130,9 @@ public function add($messages, $domain = 'messages')
         if (!isset($this->messages[$domain])) {
             $this->messages[$domain] = $messages;
         } else {
-            $this->messages[$domain] = array_replace($this->messages[$domain], $messages);
+            foreach ($messages as $id => $message) {
+                $this->messages[$domain][$id] = $message;
+            }
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,9 @@ public function add($messages, $domain = 'messages')`
`130`	`130`	`if (!isset($this->messages[$domain])) {`
`131`	`131`	`$this->messages[$domain] = $messages;`
`132`	`132`	`} else {`
`133`		`- $this->messages[$domain] = array_replace($this->messages[$domain], $messages);`
	`133`	`+ foreach ($messages as $id => $message) {`
	`134`	`+ $this->messages[$domain][$id] = $message;`
	`135`	`+ }`
`134`	`136`	`}`
`135`	`137`	`}`
`136`	`138`