minor #48269 [HttpKernel] Remove duplicate+unclear deprecation (nicolas-grekas)

fabpot · fabpot · commit 521d210ca164 · 2022-11-22T08:06:14.000+01:00
This PR was merged into the 6.2 branch. Discussion ---------- [HttpKernel] Remove duplicate+unclear deprecation | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Spotted during the workshop at SymfonyCon: when a not-updated ArgumentValueResolver is decorated, this currently throws `The "Symfony\Component\HttpKernel\Controller\ArgumentResolver\TraceableValueResolver::supports()" method is deprecated, use "resolve()" instead.`, which is not actionable + is duplicate, since we also trigger `The "EasyCorp\Bundle\EasyAdminBundle\ArgumentResolver\AdminContextResolver" class implements "Symfony\Component\HttpKernel\Controller\ArgumentValueResolverInterface" that is deprecated since Symfony 6.2, implement ValueResolverInterface instead.`. Commits ------- 99fca7b [HttpKernel] Remove duplicate+unclear deprecation
diff --git a/src/Symfony/Component/HttpKernel/Controller/ArgumentResolver/TraceableValueResolver.php b/src/Symfony/Component/HttpKernel/Controller/ArgumentResolver/TraceableValueResolver.php
@@ -42,8 +42,6 @@ public function supports(Request $request, ArgumentMetadata $argument): bool
             return true;
         }
 
-        @trigger_deprecation('symfony/http-kernel', '6.2', 'The "%s()" method is deprecated, use "resolve()" instead.', __METHOD__);
-
         $method = \get_class($this->inner).'::'.__FUNCTION__;
         $this->stopwatch->start($method, 'controller.argument_value_resolver');
 

Original file line number	Diff line number	Diff line change
`@@ -42,8 +42,6 @@ public function supports(Request $request, ArgumentMetadata $argument): bool`
`42`	`42`	`return true;`
`43`	`43`	`}`
`44`	`44`
`45`		`- @trigger_deprecation('symfony/http-kernel', '6.2', 'The "%s()" method is deprecated, use "resolve()" instead.', __METHOD__);`
`46`		`-`
`47`	`45`	`$method = \get_class($this->inner).'::'.__FUNCTION__;`
`48`	`46`	`$this->stopwatch->start($method, 'controller.argument_value_resolver');`
`49`	`47`