remove the ability to pass a tag to FormThemeNode

xabbuh · xabbuh · commit 5726e657ef22 · 2025-07-07T08:53:25.000+02:00
diff --git a/UPGRADE-8.0.md b/UPGRADE-8.0.md
@@ -491,6 +491,7 @@ Translation
 TwigBridge
 ----------
 
+ * Remove support for passing a tag to the constructor of `FormThemeNode`
  * Remove `text` format from the `debug:twig` command, use the `txt` format instead
 
 TwigBundle
diff --git a/src/Symfony/Bridge/Twig/CHANGELOG.md b/src/Symfony/Bridge/Twig/CHANGELOG.md
@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+8.0
+---
+
+ * Remove support for passing a tag to the constructor of `FormThemeNode`
+
 7.3
 ---
 
diff --git a/src/Symfony/Bridge/Twig/Node/FormThemeNode.php b/src/Symfony/Bridge/Twig/Node/FormThemeNode.php
@@ -22,18 +22,8 @@
 #[YieldReady]
 final class FormThemeNode extends Node
 {
-    /**
-     * @param bool $only
-     */
-    public function __construct(Node $form, Node $resources, int $lineno, $only = false)
+    public function __construct(Node $form, Node $resources, int $lineno, bool $only = false)
     {
-        if (null === $only || \is_string($only)) {
-            trigger_deprecation('symfony/twig-bridge', '3.12', 'Passing a tag to %s() is deprecated.', __METHOD__);
-            $only = \func_num_args() > 4 ? func_get_arg(4) : true;
-        } elseif (!\is_bool($only)) {
-            throw new \TypeError(\sprintf('Argument 4 passed to "%s()" must be a boolean, "%s" given.', __METHOD__, get_debug_type($only)));
-        }
-
         parent::__construct(['form' => $form, 'resources' => $resources], ['only' => $only], $lineno);
     }
 
diff --git a/src/Symfony/Bridge/Twig/composer.json b/src/Symfony/Bridge/Twig/composer.json
@@ -17,7 +17,6 @@
     ],
     "require": {
         "php": ">=8.4",
-        "symfony/deprecation-contracts": "^2.5|^3",
         "symfony/translation-contracts": "^2.5|^3",
         "twig/twig": "^3.21"
     },

Original file line number	Diff line number	Diff line change
`@@ -22,18 +22,8 @@`
`22`	`22`	`#[YieldReady]`
`23`	`23`	`final class FormThemeNode extends Node`
`24`	`24`	`{`
`25`		`- /**`
`26`		`- * @param bool $only`
`27`		`- */`
`28`		`- public function __construct(Node $form, Node $resources, int $lineno, $only = false)`
	`25`	`+ public function __construct(Node $form, Node $resources, int $lineno, bool $only = false)`
`29`	`26`	`{`
`30`		`- if (null === $only \|\| \is_string($only)) {`
`31`		`- trigger_deprecation('symfony/twig-bridge', '3.12', 'Passing a tag to %s() is deprecated.', __METHOD__);`
`32`		`- $only = \func_num_args() > 4 ? func_get_arg(4) : true;`
`33`		`- } elseif (!\is_bool($only)) {`
`34`		`- throw new \TypeError(\sprintf('Argument 4 passed to "%s()" must be a boolean, "%s" given.', __METHOD__, get_debug_type($only)));`
`35`		`- }`
`36`		`-`
`37`	`27`	`parent::__construct(['form' => $form, 'resources' => $resources], ['only' => $only], $lineno);`
`38`	`28`	`}`
`39`	`29`