bug #43270 [VarDumper] Fix handling of "new" in initializers on PHP 8.1 (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 57f5df5416f8 · 2021-10-05T09:43:02.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [VarDumper] Fix handling of "new" in initializers on PHP 8.1 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Part of #41552 | License | MIT | Doc PR | - Commits ------- f617c0b [VarDumper] Fix handling of "new" in initializers on PHP 8.1
diff --git a/src/Symfony/Component/VarDumper/Caster/ReflectionCaster.php b/src/Symfony/Component/VarDumper/Caster/ReflectionCaster.php
@@ -356,6 +356,8 @@ public static function getSignature(array $a)
                     $signature .= 10 > \strlen($v) && !str_contains($v, '\\') ? "'{$v}'" : "'…".\strlen($v)."'";
                 } elseif (\is_bool($v)) {
                     $signature .= $v ? 'true' : 'false';
+                } elseif (\is_object($v)) {
+                    $signature .= 'new '.substr(strrchr('\\'.get_debug_type($v), '\\'), 1);
                 } else {
                     $signature .= $v;
                 }
diff --git a/src/Symfony/Component/VarDumper/Tests/Caster/ReflectionCasterTest.php b/src/Symfony/Component/VarDumper/Tests/Caster/ReflectionCasterTest.php
@@ -586,6 +586,27 @@ public function testGenerator()
         $this->assertDumpMatchesFormat($expectedDump, $generator);
     }
 
+    /**
+     * @requires PHP 8.1
+     */
+    public function testNewInInitializer()
+    {
+        $f = eval('return function ($a = new stdClass()) {};');
+        $line = __LINE__ - 1;
+
+        $this->assertDumpMatchesFormat(
+            <<<EOTXT
+Closure(\$a = new stdClass) {
+  class: "Symfony\Component\VarDumper\Tests\Caster\ReflectionCasterTest"
+  this: Symfony\Component\VarDumper\Tests\Caster\ReflectionCasterTest { …}
+  file: "%sReflectionCasterTest.php($line) : eval()'d code"
+  line: "1 to 1"
+}
+EOTXT
+            , $f
+        );
+    }
+
     public static function stub(): void
     {
     }

Original file line number	Diff line number	Diff line change
`@@ -356,6 +356,8 @@ public static function getSignature(array $a)`
`356`	`356`	`$signature .= 10 > \strlen($v) && !str_contains($v, '\\') ? "'{$v}'" : "'…".\strlen($v)."'";`
`357`	`357`	`} elseif (\is_bool($v)) {`
`358`	`358`	`$signature .= $v ? 'true' : 'false';`
	`359`	`+ } elseif (\is_object($v)) {`
	`360`	`+ $signature .= 'new '.substr(strrchr('\\'.get_debug_type($v), '\\'), 1);`
`359`	`361`	`} else {`
`360`	`362`	`$signature .= $v;`
`361`	`363`	`}`