[Console] allow Command::getName() to return null

nicolas-grekas · nicolas-grekas · commit 59ad6c29d104 · 2019-08-29T18:09:35.000+02:00
diff --git a/src/Symfony/Component/Console/Application.php b/src/Symfony/Component/Console/Application.php
@@ -21,6 +21,7 @@
 use Symfony\Component\Console\Event\ConsoleTerminateEvent;
 use Symfony\Component\Console\Exception\CommandNotFoundException;
 use Symfony\Component\Console\Exception\ExceptionInterface;
+use Symfony\Component\Console\Exception\LogicException;
 use Symfony\Component\Console\Formatter\OutputFormatter;
 use Symfony\Component\Console\Helper\DebugFormatterHelper;
 use Symfony\Component\Console\Helper\FormatterHelper;
@@ -459,6 +460,10 @@ public function add(Command $command)
         // Will throw if the command is not correctly initialized.
         $command->getDefinition();
 
+        if (!$command->getName()) {
+            throw new LogicException(sprintf('The command defined in "%s" cannot have an empty name.', \get_class($command)));
+        }
+
         $this->commands[$command->getName()] = $command;
 
         foreach ($command->getAliases() as $alias) {
diff --git a/src/Symfony/Component/Console/Command/Command.php b/src/Symfony/Component/Console/Command/Command.php
@@ -453,14 +453,10 @@ public function setProcessTitle($title)
     /**
      * Returns the command name.
      *
-     * @return string The command name
+     * @return string|null
      */
     public function getName()
     {
-        if (!$this->name) {
-            throw new LogicException(sprintf('The command defined in "%s" cannot have an empty name.', \get_class($this)));
-        }
-
         return $this->name;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -453,14 +453,10 @@ public function setProcessTitle($title)`
`453`	`453`	`/**`
`454`	`454`	`* Returns the command name.`
`455`	`455`	`*`
`456`		`- * @return string The command name`
	`456`	`+ * @return string\|null`
`457`	`457`	`*/`
`458`	`458`	`public function getName()`
`459`	`459`	`{`
`460`		`- if (!$this->name) {`
`461`		`- throw new LogicException(sprintf('The command defined in "%s" cannot have an empty name.', \get_class($this)));`
`462`		`- }`
`463`		`-`
`464`	`460`	`return $this->name;`
`465`	`461`	`}`
`466`	`462`