bug #57853 [Console] Fix side-effects from running bash completions (Seldaek)

nicolas-grekas · nicolas-grekas · commit 5d0fa8e0db82 · 2024-08-13T18:31:56.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [Console] Fix side-effects from running bash completions | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix composer/composer#12015 | License | MIT Fixes issues in symfony bash completions having side-effects for other completions. See composer/composer#12015 for details. I identified this IFS line as causing the issue.. But it was introduced here e9e0c07 (cc `@GromNaN`) probably for a good reason. So I don't think this is mergeable as is, but we should see what can be done to set IFS where needed per process call and not change it globally like that. Commits ------- 5456645 [Console] Fix side-effects from running bash completions
diff --git a/src/Symfony/Component/Console/Resources/completion.bash b/src/Symfony/Component/Console/Resources/completion.bash
@@ -7,7 +7,7 @@
 
 _sf_{{ COMMAND_NAME }}() {
     # Use newline as only separator to allow space in completion values
-    IFS=$'\n'
+    local IFS=$'\n'
     local sf_cmd="${COMP_WORDS[0]}"
 
     # for an alias, get the real script behind it
