bug #54971 [Serializer] Cache readability/writability computation (mtarld)

fabpot · fabpot · commit 5f7ee321a3bb · 2024-05-21T07:44:15.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- [Serializer] Cache readability/writability computation | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #54865 | License | MIT Add in memory cache to reduce the number of times we check whether a property is readable or writable. Commits ------- 94fd291 [Serializer] Cache readability/writability computation
diff --git a/src/Symfony/Component/Serializer/Normalizer/ObjectNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/ObjectNormalizer.php
@@ -35,6 +35,8 @@
 class ObjectNormalizer extends AbstractObjectNormalizer
 {
     private static $reflectionCache = [];
+    private static $isReadableCache = [];
+    private static $isWritableCache = [];
 
     protected $propertyAccessor;
     protected $propertyInfoExtractor;
@@ -185,21 +187,23 @@ protected function isAllowedAttribute($classOrObject, string $attribute, ?string
         if (!parent::isAllowedAttribute($classOrObject, $attribute, $format, $context)) {
             return false;
         }
+
         $class = \is_object($classOrObject) ? \get_class($classOrObject) : $classOrObject;
 
         if ($context['_read_attributes'] ?? true) {
-            return $this->propertyInfoExtractor->isReadable($class, $attribute) || $this->hasAttributeAccessorMethod($class, $attribute);
-        }
+            if (!isset(self::$isReadableCache[$class.$attribute])) {
+                self::$isReadableCache[$class.$attribute] = $this->propertyInfoExtractor->isReadable($class, $attribute) || $this->hasAttributeAccessorMethod($class, $attribute);
+            }
 
-        if ($this->propertyInfoExtractor->isWritable($class, $attribute)) {
-            return true;
+            return self::$isReadableCache[$class.$attribute];
         }
 
-        if (($writeInfo = $this->writeInfoExtractor->getWriteInfo($class, $attribute)) && PropertyWriteInfo::TYPE_NONE !== $writeInfo->getType()) {
-            return true;
+        if (!isset(self::$isWritableCache[$class.$attribute])) {
+            self::$isWritableCache[$class.$attribute] = $this->propertyInfoExtractor->isWritable($class, $attribute)
+                || (($writeInfo = $this->writeInfoExtractor->getWriteInfo($class, $attribute)) && PropertyWriteInfo::TYPE_NONE !== $writeInfo->getType());
         }
 
-        return false;
+        return self::$isWritableCache[$class.$attribute];
     }
 
     private function hasAttributeAccessorMethod(string $class, string $attribute): bool
