bug #16676 [HttpFoundation] Workaround HHVM rewriting HTTP response line (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 5f93188dc064 · 2015-11-26T10:19:28.000+01:00
This PR was merged into the 2.3 branch. Discussion ---------- [HttpFoundation] Workaround HHVM rewriting HTTP response line | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16481, #9365 | License | MIT | Doc PR | - Commits ------- 5013f98 [HttpFoundation] Workaround HHVM rewriting HTTP response line
diff --git a/src/Symfony/Component/HttpFoundation/Response.php b/src/Symfony/Component/HttpFoundation/Response.php
@@ -268,16 +268,16 @@ public function sendHeaders()
             return $this;
         }
 
-        // status
-        header(sprintf('HTTP/%s %s %s', $this->version, $this->statusCode, $this->statusText));
-
         // headers
         foreach ($this->headers->allPreserveCase() as $name => $values) {
             foreach ($values as $value) {
                 header($name.': '.$value, false);
             }
         }
 
+        // status
+        header(sprintf('HTTP/%s %s %s', $this->version, $this->statusCode, $this->statusText), true, $this->statusCode);
+
         // cookies
         foreach ($this->headers->getCookies() as $cookie) {
             setcookie($cookie->getName(), $cookie->getValue(), $cookie->getExpiresTime(), $cookie->getPath(), $cookie->getDomain(), $cookie->isSecure(), $cookie->isHttpOnly());

Original file line number	Diff line number	Diff line change
`@@ -268,16 +268,16 @@ public function sendHeaders()`
`268`	`268`	`return $this;`
`269`	`269`	`}`
`270`	`270`
`271`		`- // status`
`272`		`- header(sprintf('HTTP/%s %s %s', $this->version, $this->statusCode, $this->statusText));`
`273`		`-`
`274`	`271`	`// headers`
`275`	`272`	`foreach ($this->headers->allPreserveCase() as $name => $values) {`
`276`	`273`	`foreach ($values as $value) {`
`277`	`274`	`header($name.': '.$value, false);`
`278`	`275`	`}`
`279`	`276`	`}`
`280`	`277`
	`278`	`+ // status`
	`279`	`+ header(sprintf('HTTP/%s %s %s', $this->version, $this->statusCode, $this->statusText), true, $this->statusCode);`
	`280`	`+`
`281`	`281`	`// cookies`
`282`	`282`	`foreach ($this->headers->getCookies() as $cookie) {`
`283`	`283`	`setcookie($cookie->getName(), $cookie->getValue(), $cookie->getExpiresTime(), $cookie->getPath(), $cookie->getDomain(), $cookie->isSecure(), $cookie->isHttpOnly());`