[TypeInfo] Fix handling ConstFetchNode

norkunas · norkunas · commit 606a4ab1c632 · 2025-06-19T13:23:33.000+03:00
diff --git a/src/Symfony/Component/PropertyInfo/Tests/Extractor/PhpStanExtractorTest.php b/src/Symfony/Component/PropertyInfo/Tests/Extractor/PhpStanExtractorTest.php
@@ -927,7 +927,7 @@ public static function unionTypesProvider(): iterable
             Type::object(ParentDummy::class),
             Type::null(),
         )];
-        yield ['f', null];
+        yield ['f', Type::union(Type::string(), Type::null())];
         yield ['g', Type::array(Type::union(Type::string(), Type::int()))];
     }
 
diff --git a/src/Symfony/Component/TypeInfo/Tests/Fixtures/DummyWithConstants.php b/src/Symfony/Component/TypeInfo/Tests/Fixtures/DummyWithConstants.php
@@ -0,0 +1,33 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\TypeInfo\Tests\Fixtures;
+
+final class DummyWithConstants
+{
+    public const DUMMY_STRING_A = 'a';
+    public const DUMMY_INT_A = 1;
+    public const DUMMY_FLOAT_A = 1.23;
+    public const DUMMY_TRUE_A = true;
+    public const DUMMY_FALSE_A = false;
+    public const DUMMY_NULL_A = null;
+    public const DUMMY_ARRAY_A = [];
+    public const DUMMY_ENUM_A = DummyEnum::ONE;
+
+    public const DUMMY_MIX_1 = self::DUMMY_STRING_A;
+    public const DUMMY_MIX_2 = self::DUMMY_INT_A;
+    public const DUMMY_MIX_3 = self::DUMMY_FLOAT_A;
+    public const DUMMY_MIX_4 = self::DUMMY_TRUE_A;
+    public const DUMMY_MIX_5 = self::DUMMY_FALSE_A;
+    public const DUMMY_MIX_6 = self::DUMMY_NULL_A;
+    public const DUMMY_MIX_7 = self::DUMMY_ARRAY_A;
+    public const DUMMY_MIX_8 = self::DUMMY_ENUM_A;
+}
diff --git a/src/Symfony/Component/TypeInfo/Tests/TypeResolver/StringTypeResolverTest.php b/src/Symfony/Component/TypeInfo/Tests/TypeResolver/StringTypeResolverTest.php
@@ -19,6 +19,7 @@
 use Symfony\Component\TypeInfo\Tests\Fixtures\DummyBackedEnum;
 use Symfony\Component\TypeInfo\Tests\Fixtures\DummyCollection;
 use Symfony\Component\TypeInfo\Tests\Fixtures\DummyEnum;
+use Symfony\Component\TypeInfo\Tests\Fixtures\DummyWithConstants;
 use Symfony\Component\TypeInfo\Tests\Fixtures\DummyWithTemplates;
 use Symfony\Component\TypeInfo\Type;
 use Symfony\Component\TypeInfo\TypeContext\TypeContext;
@@ -90,6 +91,19 @@ public static function resolveDataProvider(): iterable
         yield [Type::string(), '"string"'];
         yield [Type::true(), 'true'];
 
+        // const fetch
+        yield [Type::string(), DummyWithConstants::class.'::DUMMY_STRING_*'];
+        yield [Type::string(), DummyWithConstants::class.'::DUMMY_STRING_A'];
+        yield [Type::int(), DummyWithConstants::class.'::DUMMY_INT_*'];
+        yield [Type::int(), DummyWithConstants::class.'::DUMMY_INT_A'];
+        yield [Type::float(), DummyWithConstants::class.'::DUMMY_FLOAT_*'];
+        yield [Type::bool(), DummyWithConstants::class.'::DUMMY_TRUE_*'];
+        yield [Type::bool(), DummyWithConstants::class.'::DUMMY_FALSE_*'];
+        yield [Type::null(), DummyWithConstants::class.'::DUMMY_NULL_*'];
+        yield [Type::array(), DummyWithConstants::class.'::DUMMY_ARRAY_*'];
+        yield [Type::enum(DummyEnum::class, Type\BuiltinType::string()), DummyWithConstants::class.'::DUMMY_ENUM_*'];
+        yield [Type::union(Type::string(), Type::int(), Type::float(), Type::bool(), Type::null(), Type::array(), Type::enum(DummyEnum::class, Type\BuiltinType::string())), DummyWithConstants::class.'::DUMMY_MIX_*'];
+
         // identifiers
         yield [Type::bool(), 'bool'];
         yield [Type::bool(), 'boolean'];
diff --git a/src/Symfony/Component/TypeInfo/TypeResolver/StringTypeResolver.php b/src/Symfony/Component/TypeInfo/TypeResolver/StringTypeResolver.php
@@ -18,6 +18,7 @@
 use PHPStan\PhpDocParser\Ast\ConstExpr\ConstExprNullNode;
 use PHPStan\PhpDocParser\Ast\ConstExpr\ConstExprStringNode;
 use PHPStan\PhpDocParser\Ast\ConstExpr\ConstExprTrueNode;
+use PHPStan\PhpDocParser\Ast\ConstExpr\ConstFetchNode;
 use PHPStan\PhpDocParser\Ast\Type\ArrayShapeNode;
 use PHPStan\PhpDocParser\Ast\Type\ArrayTypeNode;
 use PHPStan\PhpDocParser\Ast\Type\CallableTypeNode;
@@ -119,6 +120,40 @@ private function getTypeFromNode(TypeNode $node, ?TypeContext $typeContext): Typ
         }
 
         if ($node instanceof ConstTypeNode) {
+            if ($node->constExpr instanceof ConstFetchNode) {
+                $types = [];
+
+                $className = match (strtolower($node->constExpr->className)) {
+                    'self' => $typeContext->getDeclaringClass(),
+                    'static' => $typeContext->getCalledClass(),
+                    'parent' => $typeContext->getParentClass(),
+                    default => $node->constExpr->className,
+                };
+
+                foreach ((new \ReflectionClass($className))->getReflectionConstants() as $const) {
+                    if (preg_match('/^'.str_replace('\*', '.*', preg_quote($node->constExpr->name, '/')).'$/', $const->getName())) {
+                        $constValue = $const->getValue();
+
+                        $types[] = match (true) {
+                            true === $constValue,
+                            false === $constValue => Type::bool(),
+                            null === $constValue => Type::null(),
+                            \is_string($constValue) => Type::string(),
+                            \is_int($constValue) => Type::int(),
+                            \is_float($constValue) => Type::float(),
+                            \is_array($constValue) => Type::array(),
+                            $constValue instanceof \UnitEnum => Type::enum($constValue::class),
+                        };
+                    }
+                }
+
+                if (\count($types) > 2) {
+                    return Type::union(...array_unique($types));
+                }
+
+                return $types[0] ?? Type::null();
+            }
+
             return match ($node->constExpr::class) {
                 ConstExprArrayNode::class => Type::array(),
                 ConstExprFalseNode::class => Type::false(),

Original file line number	Diff line number	Diff line change
`@@ -927,7 +927,7 @@ public static function unionTypesProvider(): iterable`
`927`	`927`	`Type::object(ParentDummy::class),`
`928`	`928`	`Type::null(),`
`929`	`929`	`)];`
`930`		`- yield ['f', null];`
	`930`	`+ yield ['f', Type::union(Type::string(), Type::null())];`
`931`	`931`	`yield ['g', Type::array(Type::union(Type::string(), Type::int()))];`
`932`	`932`	`}`
`933`	`933`