bug #47048 [Serializer] Fix XmlEncoder encoding attribute false (alamirault)

fabpot · fabpot · commit 6183d6643bdc · 2022-07-24T18:11:24.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [Serializer] Fix XmlEncoder encoding attribute false | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | Deprecations? | no | Tickets | Fix #47002 | License | MIT | Doc PR | ```php [ 'foo' => [ '@bar' = true, '@baz' = false, ] ] ``` Before patch: ```xml <foo bar="1" baz=""> ``` After patch: ```xml <foo bar="1" baz="0"> ``` Commits ------- a05c42e [Serializer] Fix XmlEncoder encoding attribute false
diff --git a/src/Symfony/Component/Serializer/Encoder/XmlEncoder.php b/src/Symfony/Component/Serializer/Encoder/XmlEncoder.php
@@ -417,6 +417,9 @@ private function buildXml(\DOMNode $parentNode, $data, string $format, array $co
                     if (!\is_scalar($data)) {
                         $data = $this->serializer->normalize($data, $format, $context);
                     }
+                    if (\is_bool($data)) {
+                        $data = (int) $data;
+                    }
                     $parentNode->setAttribute($attributeName, $data);
                 } elseif ('#' === $key) {
                     $append = $this->selectNodeType($parentNode, $data, $format, $context);
diff --git a/src/Symfony/Component/Serializer/Tests/Encoder/XmlEncoderTest.php b/src/Symfony/Component/Serializer/Tests/Encoder/XmlEncoderTest.php
@@ -111,6 +111,13 @@ public function testAttributes()
             'föo_bär' => 'a',
             'Bar' => [1, 2, 3],
             'a' => 'b',
+            'scalars' => [
+                '@bool-true' => true,
+                '@bool-false' => false,
+                '@int' => 3,
+                '@float' => 3.4,
+                '@sring' => 'a',
+            ],
         ];
         $expected = '<?xml version="1.0"?>'."\n".
             '<response>'.
@@ -121,6 +128,7 @@ public function testAttributes()
             '<Bar>2</Bar>'.
             '<Bar>3</Bar>'.
             '<a>b</a>'.
+            '<scalars bool-true="1" bool-false="0" int="3" float="3.4" sring="a"/>'.
             '</response>'."\n";
         $this->assertEquals($expected, $this->encoder->encode($obj, 'xml'));
     }
