feature #13324 [WebProfilerBundle] Improved page for logs (hason)

fabpot · fabpot · commit 65d4ae042942 · 2015-05-17T04:16:56.000+02:00
This PR was submitted for the 2.7 branch but it was merged into the 2.8 branch instead (closes #13324). Discussion ---------- [WebProfilerBundle] Improved page for logs | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - *Before* ![logs-before](https://cloud.githubusercontent.com/assets/288535/5661713/3942c530-972f-11e4-89cb-2e185a6d07ac.png) *After* ![logs-after](https://cloud.githubusercontent.com/assets/288535/5661681/d02b50da-972e-11e4-96e8-0572428ba82f.png) Commits ------- 5fdc650 [WebProfilerBundle] Improved page for logs
diff --git a/src/Symfony/Bridge/Monolog/Handler/DebugHandler.php b/src/Symfony/Bridge/Monolog/Handler/DebugHandler.php
@@ -35,6 +35,7 @@ public function getLogs()
                 'priority' => $record['level'],
                 'priorityName' => $record['level_name'],
                 'context' => $record['context'],
+                'channel' => isset($record['channel']) ? $record['channel'] : '',
             );
         }
 
diff --git a/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/logger.html.twig b/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/logger.html.twig
@@ -87,20 +87,30 @@
     </table>
 
     {% if collector.logs %}
-        <ul class="alt">
+        <table>
+            <tr>
+                <th>#</th>
+                <th>Priority</th>
+                <th>Channel</th>
+                <th>Message and context</th>
+            </tr>
+
             {% set log_loop_index = 0 %}
             {% for log in collector.logs %}
                 {% set is_deprecation = log.context.level is defined and log.context.type is defined and (constant('E_DEPRECATED') == log.context.type or constant('E_USER_DEPRECATED') == log.context.type) %}
                 {% if priority == '-100' ? is_deprecation : log.priority >= priority %}
                     {% set log_loop_index = log_loop_index + 1 %}
-                    <li class="{{ cycle(['odd', 'even'], log_loop_index) }}{% if log.context.scream is defined %} scream{% elseif log.priority >= 400 %} error{% elseif log.priority >= 300 or is_deprecation %} warning{% endif %}">
-                        {{ logger.display_message(loop.index, log, is_deprecation) }}
-                    </li>
+                    <tr class="{{ cycle(['odd', 'even'], log_loop_index) }}{% if log.context.scream is defined %} scream{% elseif log.priority >= 400 %} error{% elseif log.priority >= 300 or is_deprecation %} warning{% endif %}">
+                        <td>{{ log_loop_index }}</td>
+                        <td>{{ is_deprecation ? 'DEPRECATION' : log.priorityName }}</td>
+                        <td>{{ log.channel is defined ? log.channel }}</td>
+                        <td>{{ logger.display_message(loop.index, log, is_deprecation) }}</td>
+                    </tr>
                 {% endif %}
             {% else %}
-                <li><em>No logs available for this priority.</em></li>
+                <tr><td colspan="4"><em>No logs available for {{ priority }} priority.</em></td></tr>
             {% endfor %}
-        </ul>
+        </table>
     {% else %}
         <p>
             <em>No logs available.</em>
@@ -114,7 +124,7 @@
         {% set stack = log.context.stack|default([]) %}
         {% set id = 'sf-call-stack-' ~ log_index %}
 
-        DEPRECATED - {{ log.message }}
+        {{ log.message }}
 
         {% if stack %}
             <a href="#" onclick="Sfjs.toggle('{{ id }}', document.getElementById('{{ id }}-on'), document.getElementById('{{ id }}-off')); return false;">
@@ -144,7 +154,7 @@
             {% endif %}
         {% endfor %}
     {% else %}
-        {{ log.priorityName }} - {{ log.message }}
+        {{ log.message }}
         {% if log.context is defined and log.context is not empty %}
             <br />
             <small>
diff --git a/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/profiler.css.twig b/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/profiler.css.twig
@@ -179,7 +179,7 @@ pre, code {
     width: 250px;
     margin-left: -100%;
 }
-#collector-content table td {
+table td {
     background-color: white;
 }
 h1 {
@@ -273,15 +273,15 @@ ul.alt li {
 ul.alt li.even {
     background: #f1f7e2;
 }
-ul.alt li.error {
+ul.alt li.error, tr.error td {
     background-color: #f66;
     margin-bottom: 1px;
 }
-ul.alt li.warning {
+ul.alt li.warning, tr.warning td {
     background-color: #ffcc00;
     margin-bottom: 1px;
 }
-ul.alt li.scream, ul.alt li.scream strong {
+ul.alt li.scream, ul.alt li.scream strong, tr.scream td, tr.scream strong {
     color: gray;
 }
 ul.sf-call-stack li {

Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,7 @@ public function getLogs()`
`35`	`35`	`'priority' => $record['level'],`
`36`	`36`	`'priorityName' => $record['level_name'],`
`37`	`37`	`'context' => $record['context'],`
	`38`	`+ 'channel' => isset($record['channel']) ? $record['channel'] : '',`
`38`	`39`	`);`
`39`	`40`	`}`
`40`	`41`
Original file line number	Diff line number	Diff line change
`@@ -179,7 +179,7 @@ pre, code {`
`179`	`179`	`width: 250px;`
`180`	`180`	`margin-left: -100%;`
`181`	`181`	`}`
`182`		`-#collector-content table td {`
	`182`	`+table td {`
`183`	`183`	`background-color: white;`
`184`	`184`	`}`
`185`	`185`	`h1 {`
`@@ -273,15 +273,15 @@ ul.alt li {`
`273`	`273`	`ul.alt li.even {`
`274`	`274`	`background: #f1f7e2;`
`275`	`275`	`}`
`276`		`-ul.alt li.error {`
	`276`	`+ul.alt li.error, tr.error td {`
`277`	`277`	`background-color: #f66;`
`278`	`278`	`margin-bottom: 1px;`
`279`	`279`	`}`
`280`		`-ul.alt li.warning {`
	`280`	`+ul.alt li.warning, tr.warning td {`
`281`	`281`	`background-color: #ffcc00;`
`282`	`282`	`margin-bottom: 1px;`
`283`	`283`	`}`
`284`		`-ul.alt li.scream, ul.alt li.scream strong {`
	`284`	`+ul.alt li.scream, ul.alt li.scream strong, tr.scream td, tr.scream strong {`
`285`	`285`	`color: gray;`
`286`	`286`	`}`
`287`	`287`	`ul.sf-call-stack li {`