[HttpKernel][Security] Refactor: use getAttributes with argument

santysisi · santysisi · commit 6769c9a82873 · 2025-07-15T07:50:17.000-03:00
diff --git a/src/Symfony/Component/HttpKernel/EventListener/CacheAttributeListener.php b/src/Symfony/Component/HttpKernel/EventListener/CacheAttributeListener.php
@@ -51,7 +51,7 @@ public function onKernelControllerArguments(ControllerArgumentsEvent $event): vo
     {
         $request = $event->getRequest();
 
-        if (!\is_array($attributes = $request->attributes->get('_cache') ?? $event->getAttributes()[Cache::class] ?? null)) {
+        if (!$attributes = $request->attributes->get('_cache') ?? $event->getAttributes(Cache::class)) {
             return;
         }
 
diff --git a/src/Symfony/Component/Security/Http/EventListener/IsCsrfTokenValidAttributeListener.php b/src/Symfony/Component/Security/Http/EventListener/IsCsrfTokenValidAttributeListener.php
@@ -35,8 +35,7 @@ public function __construct(
 
     public function onKernelControllerArguments(ControllerArgumentsEvent $event): void
     {
-        /** @var IsCsrfTokenValid[] $attributes */
-        if (!\is_array($attributes = $event->getAttributes()[IsCsrfTokenValid::class] ?? null)) {
+        if (!$attributes = $event->getAttributes(IsCsrfTokenValid::class)) {
             return;
         }
 
diff --git a/src/Symfony/Component/Security/Http/EventListener/IsGrantedAttributeListener.php b/src/Symfony/Component/Security/Http/EventListener/IsGrantedAttributeListener.php
@@ -39,8 +39,7 @@ public function __construct(
 
     public function onKernelControllerArguments(ControllerArgumentsEvent $event): void
     {
-        /** @var IsGranted[] $attributes */
-        if (!\is_array($attributes = $event->getAttributes()[IsGranted::class] ?? null)) {
+        if (!$attributes = $event->getAttributes(IsGranted::class)) {
             return;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ public function onKernelControllerArguments(ControllerArgumentsEvent $event): vo`
`51`	`51`	`{`
`52`	`52`	`$request = $event->getRequest();`
`53`	`53`
`54`		`- if (!\is_array($attributes = $request->attributes->get('_cache') ?? $event->getAttributes()[Cache::class] ?? null)) {`
	`54`	`+ if (!$attributes = $request->attributes->get('_cache') ?? $event->getAttributes(Cache::class)) {`
`55`	`55`	`return;`
`56`	`56`	`}`
`57`	`57`
Original file line number	Diff line number	Diff line change
`@@ -35,8 +35,7 @@ public function __construct(`
`35`	`35`
`36`	`36`	`public function onKernelControllerArguments(ControllerArgumentsEvent $event): void`
`37`	`37`	`{`
`38`		`- /** @var IsCsrfTokenValid[] $attributes */`
`39`		`- if (!\is_array($attributes = $event->getAttributes()[IsCsrfTokenValid::class] ?? null)) {`
	`38`	`+ if (!$attributes = $event->getAttributes(IsCsrfTokenValid::class)) {`
`40`	`39`	`return;`
`41`	`40`	`}`
`42`	`41`
Original file line number	Diff line number	Diff line change
`@@ -39,8 +39,7 @@ public function __construct(`
`39`	`39`
`40`	`40`	`public function onKernelControllerArguments(ControllerArgumentsEvent $event): void`
`41`	`41`	`{`
`42`		`- /** @var IsGranted[] $attributes */`
`43`		`- if (!\is_array($attributes = $event->getAttributes()[IsGranted::class] ?? null)) {`
	`42`	`+ if (!$attributes = $event->getAttributes(IsGranted::class)) {`
`44`	`43`	`return;`
`45`	`44`	`}`
`46`	`45`