bug #49657 [HttpKernel] Change limit argument from string to integer for Profiler (Aliance)

fabpot · fabpot · commit 67b9ac93bf2a · 2023-03-13T20:11:42.000+01:00
This PR was merged into the 5.4 branch. Discussion ---------- [HttpKernel] Change limit argument from string to integer for Profiler | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #49656 | License | MIT Commits ------- fb9b0d0 Change limit argument from string to integer.
diff --git a/src/Symfony/Component/HttpKernel/Profiler/Profiler.php b/src/Symfony/Component/HttpKernel/Profiler/Profiler.php
@@ -116,15 +116,15 @@ public function purge()
     /**
      * Finds profiler tokens for the given criteria.
      *
-     * @param string|null $limit The maximum number of tokens to return
+     * @param int|null    $limit The maximum number of tokens to return
      * @param string|null $start The start date to search from
      * @param string|null $end   The end date to search to
      *
      * @return array
      *
      * @see https://php.net/datetime.formats for the supported date/time formats
      */
-    public function find(?string $ip, ?string $url, ?string $limit, ?string $method, ?string $start, ?string $end, string $statusCode = null)
+    public function find(?string $ip, ?string $url, ?int $limit, ?string $method, ?string $start, ?string $end, string $statusCode = null)
     {
         return $this->storage->find($ip, $url, $limit, $method, $this->getTimestamp($start), $this->getTimestamp($end), $statusCode);
     }

Original file line number	Diff line number	Diff line change
`@@ -116,15 +116,15 @@ public function purge()`
`116`	`116`	`/**`
`117`	`117`	`* Finds profiler tokens for the given criteria.`
`118`	`118`	`*`
`119`		`- * @param string\|null $limit The maximum number of tokens to return`
	`119`	`+ * @param int\|null $limit The maximum number of tokens to return`
`120`	`120`	`* @param string\|null $start The start date to search from`
`121`	`121`	`* @param string\|null $end The end date to search to`
`122`	`122`	`*`
`123`	`123`	`* @return array`
`124`	`124`	`*`
`125`	`125`	`* @see https://php.net/datetime.formats for the supported date/time formats`
`126`	`126`	`*/`
`127`		`- public function find(?string $ip, ?string $url, ?string $limit, ?string $method, ?string $start, ?string $end, string $statusCode = null)`
	`127`	`+ public function find(?string $ip, ?string $url, ?int $limit, ?string $method, ?string $start, ?string $end, string $statusCode = null)`
`128`	`128`	`{`
`129`	`129`	`return $this->storage->find($ip, $url, $limit, $method, $this->getTimestamp($start), $this->getTimestamp($end), $statusCode);`
`130`	`130`	`}`