[DependencyInjection] Forbid container cloning

jakzal · jakzal · commit 68fb163de3ec · 2015-07-16T09:42:48.000+01:00
diff --git a/src/Symfony/Component/DependencyInjection/Container.php b/src/Symfony/Component/DependencyInjection/Container.php
@@ -604,4 +604,8 @@ public static function underscore($id)
     {
         return strtolower(preg_replace(array('/([A-Z]+)([A-Z][a-z])/', '/([a-z\d])([A-Z])/'), array('\\1_\\2', '\\1_\\2'), strtr($id, '_', '.')));
     }
+
+    private function __clone()
+    {
+    }
 }
diff --git a/src/Symfony/Component/DependencyInjection/Tests/ContainerTest.php b/src/Symfony/Component/DependencyInjection/Tests/ContainerTest.php
@@ -662,6 +662,13 @@ public function testAlias()
         $this->assertTrue($c->has('alias'));
         $this->assertSame($c->get('alias'), $c->get('bar'));
     }
+
+    public function testThatCloningIsNotSupported()
+    {
+        $class = new \ReflectionClass('Symfony\Component\DependencyInjection\Container');
+        $clone = $class->getMethod('__clone');
+        $this->assertTrue($clone->isPrivate());
+    }
 }
 
 class ProjectServiceContainer extends Container

Original file line number	Diff line number	Diff line change
`@@ -604,4 +604,8 @@ public static function underscore($id)`
`604`	`604`	`{`
`605`	`605`	`return strtolower(preg_replace(array('/([A-Z]+)([A-Z][a-z])/', '/([a-z\d])([A-Z])/'), array('\\1_\\2', '\\1_\\2'), strtr($id, '_', '.')));`
`606`	`606`	`}`
	`607`	`+`
	`608`	`+ private function __clone()`
	`609`	`+ {`
	`610`	`+ }`
`607`	`611`	`}`
Original file line number	Diff line number	Diff line change
`@@ -662,6 +662,13 @@ public function testAlias()`
`662`	`662`	`$this->assertTrue($c->has('alias'));`
`663`	`663`	`$this->assertSame($c->get('alias'), $c->get('bar'));`
`664`	`664`	`}`
	`665`	`+`
	`666`	`+ public function testThatCloningIsNotSupported()`
	`667`	`+ {`
	`668`	`+ $class = new \ReflectionClass('Symfony\Component\DependencyInjection\Container');`
	`669`	`+ $clone = $class->getMethod('__clone');`
	`670`	`+ $this->assertTrue($clone->isPrivate());`
	`671`	`+ }`
`665`	`672`	`}`
`666`	`673`
`667`	`674`	`class ProjectServiceContainer extends Container`