Remove parameter from jsonRequest

alexander-schranz · alexander-schranz · commit 696a3f8fe4d2 · 2020-10-16T12:21:22.000+02:00
diff --git a/src/Symfony/Component/BrowserKit/AbstractBrowser.php b/src/Symfony/Component/BrowserKit/AbstractBrowser.php
@@ -164,15 +164,15 @@ public function xmlHttpRequest(string $method, string $uri, array $parameters =
     /**
      * Converts the request parameters into a json string and use it as request content.
      */
-    public function jsonRequest(string $method, string $uri, array $parameters = [], array $files = [], array $server = [], bool $changeHistory = true): Crawler
+    public function jsonRequest(string $method, string $uri, array $parameters = [], array $server = [], bool $changeHistory = true): Crawler
     {
         $content = json_encode($parameters);
 
         $this->setServerParameter('CONTENT_TYPE', 'application/json');
         $this->setServerParameter('HTTP_ACCEPT', 'application/json');
 
         try {
-            return $this->request($method, $uri, [], $files, $server, $content, $changeHistory);
+            return $this->request($method, $uri, [], [], $server, $content, $changeHistory);
         } finally {
             unset($this->server['CONTENT_TYPE']);
             unset($this->server['HTTP_ACCEPT']);
@@ -455,7 +455,7 @@ protected function doRequestInProcess($request)
             foreach ($deprecations ? unserialize($deprecations) : [] as $deprecation) {
                 if ($deprecation[0]) {
                     // unsilenced on purpose
-                    @trigger_error($deprecation[1], \E_USER_DEPRECATED);
+                    trigger_error($deprecation[1], \E_USER_DEPRECATED);
                 } else {
                     @trigger_error($deprecation[1], \E_USER_DEPRECATED);
                 }
diff --git a/src/Symfony/Component/BrowserKit/Tests/AbstractBrowserTest.php b/src/Symfony/Component/BrowserKit/Tests/AbstractBrowserTest.php
@@ -63,7 +63,7 @@ public function testXmlHttpRequest()
     public function testJsonRequest()
     {
         $client = $this->getBrowser();
-        $client->jsonRequest('GET', 'http://example.com/', ['param' => 1], [], [], true);
+        $client->jsonRequest('GET', 'http://example.com/', ['param' => 1], [], true);
         $this->assertEquals($client->getRequest()->getServer()['CONTENT_TYPE'], 'application/json');
         $this->assertEquals($client->getRequest()->getServer()['HTTP_ACCEPT'], 'application/json');
         $this->assertFalse($client->getServerParameter('CONTENT_TYPE', false));

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ public function testXmlHttpRequest()`
`63`	`63`	`public function testJsonRequest()`
`64`	`64`	`{`
`65`	`65`	`$client = $this->getBrowser();`
`66`		`- $client->jsonRequest('GET', 'http://example.com/', ['param' => 1], [], [], true);`
	`66`	`+ $client->jsonRequest('GET', 'http://example.com/', ['param' => 1], [], true);`
`67`	`67`	`$this->assertEquals($client->getRequest()->getServer()['CONTENT_TYPE'], 'application/json');`
`68`	`68`	`$this->assertEquals($client->getRequest()->getServer()['HTTP_ACCEPT'], 'application/json');`
`69`	`69`	`$this->assertFalse($client->getServerParameter('CONTENT_TYPE', false));`